Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScrollView experiments #1442

Merged
merged 8 commits into from
Aug 7, 2023

Conversation

siepra
Copy link
Contributor

@siepra siepra commented Aug 7, 2023

Summary

I added an experiment for ScrollView.

I simply copied the example from official docs https://reactnative.dev/docs/scrollview and attached logger for every event prefixed with 'on' word.

I'm marking it as draft for now as I plan to continue with FlatList and SectionList within the same PR.

@siepra
Copy link
Contributor Author

siepra commented Aug 7, 2023

Oh, sorry for not following the commit naming convention. I focused on the branch name instead (my bad). I promise to obey from now on

@mdjastrzebski mdjastrzebski marked this pull request as ready for review August 7, 2023 20:23
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b70c07d) 97.56% compared to head (f4303d5) 97.56%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1442   +/-   ##
=======================================
  Coverage   97.56%   97.56%           
=======================================
  Files          72       72           
  Lines        4266     4266           
  Branches      631      631           
=======================================
  Hits         4162     4162           
  Misses        104      104           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mdjastrzebski mdjastrzebski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I've done some minor tweaks to matching code style of the other experiments.

@mdjastrzebski mdjastrzebski merged commit ca0d9a5 into callstack:main Aug 7, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants