Fosnola's fix #101 #438
Closed
Fosnola's fix #101 #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing a Windows scenario note: this may be succeptible to break the loading of some legacy save, but there are already broken....
|
This bug would actually be a good candidate for having a unit test. |
|
Any ideas on what that unit test could look like? We could add it in this PR as well. |
|
It could load the legacy test scenarios and check the town boundary
rectangles directly to make assertions.
Where would you want me to put test scenarios in the repository?
…On Mon, Sep 9, 2024 at 6:33 PM Celtic Minstrel ***@***.***> wrote:
Any ideas on what that unit test could look like? We could add it in this
PR as well.
—
Reply to this email directly, view it on GitHub
<#438 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AATXBKOG67FRBB3JVZSBFZTZVYV3DAVCNFSM6AAAAABN5NTKBGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZZGMZDSMJRGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
I guess they could go in rsrc/ in a new folder, like test or test-scenarios or something like that. The other option would be in test/files/. |
|
Closed in favor of #441 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've cherry-picked and amended (to remove extraneous changes) one of the commit's @fosnola said fixes issue #101, and after testing, it seems that the fix works. (However, I can in no way guarantee that it doesn't break anything else.)
There was an additional commit fosnola mentioned, fosnola@d63b089 , but I looked through that one and I can't tell how it's related to town boundaries. Also it has merge conflicts against our master branch, so I thought I'd leave it alone for now.
Edit: I also don't know how it could break legacy saves, or if that other commit was to fix that potential problem.