Fix #451

[NQNStudios]

No description provided.

[CelticMinstrel]

This isn't really related, but I just realized that the filename += buffer line might be unsafe. I'm not sure if it correctly accounts for the fact that the buffer is known to be 128 characters.

[NQNStudios]

That's here, for conversational reference:

cboe/src/tools/winutil.linux.cpp

Line 146 in f4c34a4

filename += buffer;

Also, is it reading chunks of 128 characters at a time from a command? Why not just read 1 at a time until it reaches the end rather than request more than is known to be there?

[CelticMinstrel]

I don't really know. I assume that requesting 128 characters when there are only 30 characters is fine though.

[NQNStudios]

So, what would make it safe? Setting the index after the end of the buffer to the zero/null terminator? Constructing a std::string before calling += ?

[CelticMinstrel]

I was thinking using std::append instead of +=, as there's a form of that which takes a count. But then I looked at the fgets documentation and realized that it actually reads only 127 characters and adds a null terminator, so += seems to be safe after all.