-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md to address #462 #464
Conversation
…huh? Why not? |
Vcpkg has two modes: manifest mode (which we use in the CI to lock the
dependency versions) and classic mode (which we are telling people to use
here). In Visual Studio 2022 Community edition I found out yesterday that
they’ve disabled classic mode in the built-in vcpkg.
So an alternative here would be to change this instruction to tell them to
use manifest mode. For some reason, we didn’t make that change in the docs
when we made it in the CI. I don’t remember if there was a good reason.
…On Tue, Nov 5, 2024 at 11:04 PM Celtic Minstrel ***@***.***> wrote:
You can't use the vcpkg installation that comes with Visual Studio for
these commands.
…huh? Why not?
—
Reply to this email directly, view it on GitHub
<#464 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AATXBKJFZONSNGF2QY5SJGDZ7GPNZAVCNFSM6AAAAABRHAWVPWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJYG4ZTEMJYGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So an alternative here would be to change this instruction to tell them to
use manifest mode.
What does that actually entail? How would the install commands differ?
As it happens, I think the install command would get simpler, with a caveat that you must call it from inside proj/vs2017 or proj\vs2013.
And this would help us avoid new contributors getting a new version of boost that scons can't find. |
I'm gonna go ahead and make that change. |
Could be made more concise, and might not be git beginner-friendly enough, but I made some edits that should make our recurring problem stated in #462 less common by being extremely explicit and using bold/capitalized text and a heading.