Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md to address #462 #464

Merged
merged 5 commits into from
Nov 9, 2024
Merged

Conversation

NQNStudios
Copy link
Collaborator

Could be made more concise, and might not be git beginner-friendly enough, but I made some edits that should make our recurring problem stated in #462 less common by being extremely explicit and using bold/capitalized text and a heading.

@CelticMinstrel
Copy link
Member

You can't use the vcpkg installation that comes with Visual Studio for
these commands.

…huh? Why not?

@NQNStudios
Copy link
Collaborator Author

NQNStudios commented Nov 6, 2024 via email

Copy link
Member

@CelticMinstrel CelticMinstrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So an alternative here would be to change this instruction to tell them to
use manifest mode.

What does that actually entail? How would the install commands differ?

@NQNStudios
Copy link
Collaborator Author

As it happens, I think the install command would get simpler, with a caveat that you must call it from inside proj/vs2017 or proj\vs2013.

C:\Users\natqu\repos\cboe\proj\vs2017>vcpkg install --triplet=x64-windows

And this would help us avoid new contributors getting a new version of boost that scons can't find.

@NQNStudios
Copy link
Collaborator Author

I'm gonna go ahead and make that change.

@CelticMinstrel CelticMinstrel merged commit 6f293d9 into calref:master Nov 9, 2024
6 checks passed
@NQNStudios NQNStudios deleted the patch-1 branch November 30, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants