WIP: add LogEntry interface to replace monolithic PaymenDescriptor type
#8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull reviewers statsStats of the last 30 days for lnd:
|
Ran into a tricky to debug issue where forwarding nodes in a multi-hop payment incorrectly compute the balance for the remote party when handling a ChildLogEntry (Settle/Fail), end up missing an output on the commitment transaction, and then send a CommitSig that our peer fails to validate, as it does not match the view they were expecting given the updates they've sent.
use AddLogEntry before we create Settle/FailLogEntry
remove all traces of PaymentDescriptor from test cases as well
calvinrzachman
force-pushed
the
log-entry
branch
from
2c06ed5 to
9fc2dbd
Compare
calvinrzachman
changed the title
LogEntry interface to replace monolithic PaymenDescriptor typeLogEntry interface to replace monolithic PaymenDescriptor type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This is not review ready.
The motivation for this PR comes via a request from Laolu to consider removing the
PaymentDescriptortype and replacing it with aLogEntryinterface for our in-memory HTLC update log.We separate the relevant
LogEntryinterface bits from Laolu's Dynamic Commitment PR, fix a couple bugs, and...TODO:
Change Description
Description of change / link to associated issue.
Steps to Test
Steps for reviewers to follow to test the change.
Pull Request Checklist
Testing
Code Style and Documentation
[skip ci]in the commit message for small changes.📝 Please see our Contribution Guidelines for further guidance.