Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Version for M4 #154

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

FabrizioMoggio
Copy link
Collaborator

release number update to v0.3.0

What type of PR is this?

  • documentation

What this PR does / why we need it:

This PR updates the release version to 0.3.0. Stable release for M4.

Which issue(s) this PR fixes:

#153

release number update to v0.3.0: camaraproject#153
@FabrizioMoggio FabrizioMoggio requested a review from a team February 24, 2025 14:43
@hdamker
Copy link
Contributor

hdamker commented Feb 25, 2025

@FabrizioMoggio As CallForwardingSignal was promoted to the "Incubating" stage, please do the following changes (either here in the release PR or as a separate issue and PR:

  • Badge "Incubating API Repository" applied in README
  • Text in README aligned with template README.md (see code there for the commented sections)
  • Line "Incubating stage since: February 2025" added

Copy link
Contributor

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, the PR on the template is still waiting for review and merge, but ProjectStructureAndRoles.md is already updated:

FabrizioMoggio and others added 3 commits February 25, 2025 23:27
camaraproject#156

Co-authored-by: Herbert Damker <[email protected]>
camaraproject#156

Co-authored-by: Herbert Damker <[email protected]>
camaraproject#156

Co-authored-by: Herbert Damker <[email protected]>
@FabrizioMoggio
Copy link
Collaborator Author

FabrizioMoggio commented Feb 28, 2025

@hdamker I don't get why Merging is blocked. In my understanding I have included in the PR all the requested changes, Isn't it?
@bigludo7 , @chinaunicomyangfan , as soon as the review is completed (it should already be completed, actually) it will be required also your review, I think

@FabrizioMoggio FabrizioMoggio requested a review from a team February 28, 2025 17:56
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not an expert for the test definition files, but it seems that the "CAMARA Common Artifact C02 - Test scenarios for phoneNumber errors" are not applied (maybe because also the error responses are not aligned?).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have implemented some test scenarios on phone number but not those one. Is it mandatory to be compliant with that for an Incubated API or can we align the API after Spring25?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants