Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meeting minutes: MoM-2024-01-30.md #144

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Meeting minutes: MoM-2024-01-30.md #144

merged 2 commits into from
Feb 1, 2024

Conversation

jlurien
Copy link
Collaborator

@jlurien jlurien commented Jan 29, 2024

What type of PR is this?

  • documentation

What this PR does / why we need it:

Agenda for next meeting. to be updated with minutes

@jlurien jlurien marked this pull request as ready for review January 30, 2024 13:23
@jlurien jlurien requested a review from bigludo7 as a code owner January 30, 2024 13:23
@jlurien
Copy link
Collaborator Author

jlurien commented Jan 30, 2024

@bigludo7 Please review the meeting minutes. If you need some clarification as you were not in this one, let me know. Thanks

@jlurien jlurien changed the title Create MoM-2024-01-30.md Meeting minutes: MoM-2024-01-30.md Jan 30, 2024
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jlurien for #141 not sure why waiting for Commonalities outputs.
The guidelines stated: For this specific event, the data must feature terminationReason attribute.

There is not specification of the value enumeration and with the diversity of the APIs not sure it makes sense . For me I'm afraid that going to Commonalities will take unnecessary delay for a very short point - WDYT?

@jlurien
Copy link
Collaborator Author

jlurien commented Jan 31, 2024

@jlurien for #141 not sure why waiting for Commonalities outputs. The guidelines stated: For this specific event, the data must feature terminationReason attribute.

There is not specification of the value enumeration and with the diversity of the APIs not sure it makes sense . For me I'm afraid that going to Commonalities will take unnecessary delay for a very short point - WDYT?

The question is about whether we should agree on the value for terminationReason across APIs, as I think that this case will happen for all APIs with subscriptions.

In QoD there is PR proposal that is somehow similar, to add a new reason for termination, even if in QoD there are no explicit subscriptions, and notifications are implicit to the QoS session, and there the reason value for this case is

    * `DELETE_REQUESTED`- User requested the deletion of the session before the requested duration expired

They also have NETWORK_TERMINATED as another reason.

For Geofencing I see SUBSCRIPTION_DELETED acceptable as well, but other APIs with subscriptions may decide on another value if it is not documented in Commonalities.

@jlurien jlurien merged commit b0ae9de into main Feb 1, 2024
@jlurien jlurien deleted the doc/mom-2024-01-30 branch February 6, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants