-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release r1.1 #16
Release r1.1 #16
Conversation
@yamamoto0104 |
Co-authored-by: Eric Murray <[email protected]>
Co-authored-by: Eric Murray <[email protected]>
Co-authored-by: Eric Murray <[email protected]>
Co-authored-by: Eric Murray <[email protected]>
Co-authored-by: Eric Murray <[email protected]>
Co-authored-by: Eric Murray <[email protected]>
Hello @eric-murray |
Hello @eric-murray |
The following still needs to be done before this can be approved and merged:
|
Hello @eric-murray Thank you for your comments. I updated the link and added @camaraproject/release-management_maintainers.
@Masa8106 Could you merge #18 ?
|
@yamamoto0104 Yes. I have merged PR#18. Please check it. |
Hello @eric-murray |
@eric-murray |
I would just do a merge of the upstream/main into your yamamoto_release_v0.1.0 - branch. Then you just need to take care to compare your commits with the ones from the main, but let the versions of your branch in it. |
I fixed the conflict. The following is correct for the release:
|
@eric-murray |
@hdamker and @tanjadegroot |
@yamamoto0104 The needed steps to merge this PR are as following:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great progress - ok on these changes.
waiting for the test file to be merged before.
Co-authored-by: Tanja de Groot <[email protected]>
Co-authored-by: Tanja de Groot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
for next time: merge would have needed release management approval first, but I will have a final look, but think it is all fine you should now create the release. @herbert will write the instructions and do the release |
I have check and what has been merges is OK. /LGTM from Release mnagament |
@yamamoto0104 I've created the release already to ensure that the links in your README.md are not going to 404. For your reference and the next time the steps are:
|
@hdamker Thank you for your instruction.
|
The release tag has to be on the merge commit of the release PR, so you can't create it upfront. I've seen the release PR for r1.2 and create the release review issue for it: camaraproject/ReleaseManagement#179. Please wait there for review comments and/or the approval by Release Management for the PR. |
@hdamker , OK, we'll create the release tag after approval of Release Management team. |
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Create release branch r1.1 for v0.1.0-rc.1 and include CHANGELOG