-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spring25 - M3 Milestone - Prepare r2.1 #74
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Error POPULATION_DENSITY_DATA.UNSUPPORTED_REQUEST renamed (previously "UNSUPPPORTED") Error POPULATION_DENSITY_DATA.INVALID_END_TIME renamed (previously "POPULATION_DENSITY_DATA.INVALID_END_DATE")
Fixing small typos on errors, and including adaption of ICM description as in https://github.com/camaraproject/IdentityAndConsentManagement/blob/r2.2/documentation/CAMARA-API-access-and-user-consent.md#mandatory-template-for-infodescription-in-camara-api-specs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very few comments on the release related files, see below, they are looking good.
The challenge is the missing update of the .feature file, which is mandatory for a release candidate version and with that for M3. The intention of the release candidate is that someone can take the pre-release, implement the API definition and then test it with the test definitions in the pre-release. Without the test definitions it would be an alpha version of the API.
Given the overall shape of the API and that the changes of the feature file are already prepared, we should find an exceptional way to get the updated API into the meta-release. Preferred would be that the updated .feature gets merged before this release PR to have a consistent release candidate.
documentation/API_documentation/population-density-data-API-Readiness-Checklist.md
Outdated
Show resolved
Hide resolved
documentation/API_documentation/population-density-data-API-Readiness-Checklist.md
Show resolved
Hide resolved
Co-authored-by: Herbert Damker <[email protected]>
Co-authored-by: Herbert Damker <[email protected]>
@hdamker thanks for the review, comments are included and PR of Test Plan is merged as well for solving all the pending topics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming that the API is already aligned with r2.2. of Commonalities and ICM (at least my impression), please state so and we done here! Great work!
|
||
| Nr | API release assets | alpha | release-candidate | initial<br>public | stable<br> public | Status | Comments | | ||
| Nr | API release assets | alpha | release-candidate | initial<br>public | stable<br> public | Status | Reference information | | ||
|----|----------------------------------------------|:-----:|:-----------------:|:-------:|:------:|:----:|------| | ||
| 1 | API definition | M | M | M | M | Y | [link](/code/API_definitions/population-density-data.yaml) | | ||
| 2 | Design guidelines from Commonalities applied | O | M | M | M | Y | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add here and in the next line either r2.1 or r2.2 (rc) as reference information for the release of Commonalities your API is aligned with.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jgarciahospital 👍
Co-authored-by: Herbert Damker <[email protected]>
Typos of version in .freature file solved and reference to r2.2 commonalities and ICM -rc.1 included |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version of the API definition file need to be updated here in the release PR (in main
it is still wip
which is correct, but not for the release).
Plus one minor other change.
Co-authored-by: Herbert Damker <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guess we are now there :-)
Looks good from release management perspective.
What type of PR is this?
What this PR does / why we need it:
Create rc-1 with r2.1 version of Population Density Data API for spring25 meta-release
Which issue(s) this PR fixes:
Fixes #48