Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring25 - M3 Milestone - Prepare r2.1 #74

Merged
merged 18 commits into from
Feb 10, 2025
Merged

Conversation

jgarciahospital
Copy link
Collaborator

What type of PR is this?

  • documentation
  • subproject management

What this PR does / why we need it:

Create rc-1 with r2.1 version of Population Density Data API for spring25 meta-release

Which issue(s) this PR fixes:

Fixes #48

@jgarciahospital jgarciahospital added subproject management Indicating issues with subproject repository or release management process Spring25 labels Jan 28, 2025
@jgarciahospital jgarciahospital requested review from bigludo7, gregory1g and a team January 28, 2025 11:40
Copy link

github-actions bot commented Jan 28, 2025

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 2 0 0.02s
✅ OPENAPI spectral 1 0 1.76s
✅ REPOSITORY git_diff yes no 0.03s
✅ REPOSITORY secretlint yes no 0.73s
✅ YAML yamllint 1 0 0.49s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Error POPULATION_DENSITY_DATA.UNSUPPORTED_REQUEST renamed (previously "UNSUPPPORTED")

Error POPULATION_DENSITY_DATA.INVALID_END_TIME renamed (previously "POPULATION_DENSITY_DATA.INVALID_END_DATE")
@jgarciahospital
Copy link
Collaborator Author

Copy link
Contributor

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very few comments on the release related files, see below, they are looking good.

The challenge is the missing update of the .feature file, which is mandatory for a release candidate version and with that for M3. The intention of the release candidate is that someone can take the pre-release, implement the API definition and then test it with the test definitions in the pre-release. Without the test definitions it would be an alpha version of the API.

Given the overall shape of the API and that the changes of the feature file are already prepared, we should find an exceptional way to get the updated API into the meta-release. Preferred would be that the updated .feature gets merged before this release PR to have a consistent release candidate.

@jgarciahospital
Copy link
Collaborator Author

@hdamker thanks for the review, comments are included and PR of Test Plan is merged as well for solving all the pending topics.

Copy link
Contributor

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming that the API is already aligned with r2.2. of Commonalities and ICM (at least my impression), please state so and we done here! Great work!


| Nr | API release assets | alpha | release-candidate | initial<br>public | stable<br> public | Status | Comments |
| Nr | API release assets | alpha | release-candidate | initial<br>public | stable<br> public | Status | Reference information |
|----|----------------------------------------------|:-----:|:-----------------:|:-------:|:------:|:----:|------|
| 1 | API definition | M | M | M | M | Y | [link](/code/API_definitions/population-density-data.yaml) |
| 2 | Design guidelines from Commonalities applied | O | M | M | M | Y | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add here and in the next line either r2.1 or r2.2 (rc) as reference information for the release of Commonalities your API is aligned with.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jgarciahospital 👍

@jgarciahospital
Copy link
Collaborator Author

Typos of version in .freature file solved and reference to r2.2 commonalities and ICM -rc.1 included

Copy link
Contributor

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version of the API definition file need to be updated here in the release PR (in main it is still wip which is correct, but not for the release).

Plus one minor other change.

@jgarciahospital
Copy link
Collaborator Author

The version of the API definition file need to be updated here in the release PR (in main it is still wip which is correct, but not for the release).

Plus one minor other change.

rc.1 included in API definition file.
image

Copy link
Contributor

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess we are now there :-)

Looks good from release management perspective.

@jgarciahospital jgarciahospital merged commit 247f7a3 into main Feb 10, 2025
2 checks passed
@jgarciahospital jgarciahospital deleted the jgarciahospital-patch-5 branch February 10, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Spring25 subproject management Indicating issues with subproject repository or release management process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scope discussion for Spring25 release
4 participants