Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix of reference to qos-profiles API in quality-on-demand.yaml #339

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

hdamker
Copy link
Collaborator

@hdamker hdamker commented Aug 9, 2024

What type of PR is this?

Add one of the following kinds:

  • correction

What this PR does / why we need it:

Resolve "TBC" reference leftover, see #333

Which issue(s) this PR fixes:

Fixes #333

Special notes for reviewers:

Wording to be discussed/approved in QoD call today.

Can be merged either before or after the Release PR (there would be no need to mention in r1.1 release notes as it is a correction of API split).

@hdamker hdamker linked an issue Aug 9, 2024 that may be closed by this pull request
@hdamker hdamker added the Fall24 Relevant for maintenance of Fall24 release label Aug 9, 2024
Copy link

github-actions bot commented Aug 9, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 2 0 0.03s
✅ OPENAPI spectral 3 0 5.12s
✅ REPOSITORY git_diff yes no 0.06s
✅ REPOSITORY secretlint yes no 1.13s
✅ XML xmllint 1 0 0 0.07s
✅ YAML yamllint 3 0 0.71s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@hdamker hdamker changed the title Fix of reference to cos-profiles API in quality-on-demand.yaml Fix of reference to qos-profiles API in quality-on-demand.yaml Aug 9, 2024
eric-murray
eric-murray previously approved these changes Aug 9, 2024
@eric-murray
Copy link
Collaborator

@hdamker
Copy link
Collaborator Author

hdamker commented Aug 9, 2024

This is also in qod-provisioning.yaml
https://github.com/camaraproject/QualityOnDemand/blob/main/code/API_definitions/qod-provisioning.yaml#L13

I will add it here to the same PR.

Copy link
Collaborator

@RandyLevensalor RandyLevensalor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RandyLevensalor RandyLevensalor merged commit 1b892cb into main Aug 9, 2024
1 check passed
@hdamker hdamker deleted the 333-update-reference-to-the-qos-profiles-api branch August 9, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fall24 Relevant for maintenance of Fall24 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update reference to the QoS Profiles API
3 participants