Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-credo-merge #1053

Merged
merged 6 commits into from
Jan 2, 2024
Merged

dev-credo-merge #1053

merged 6 commits into from
Jan 2, 2024

Conversation

mdhillman
Copy link
Collaborator

This PR brings in support for "parallel-world" scenarios; note however that this is based on the scenario system currently specific to the CReDo project, a feature that has not yet been ported to the generic TWA.

Additionally, support for a boolean credo flag in the settings.json file has been added to enforce the CReDo-specific URL format for metadata/timeseries queries.

A testing image has been produced (ghcr.io/cambridge-cares/twa-vf:4.3.0-SNAPSHOT), and the CReDo visualisations on that repository's dev-vf-migrate branch have been updated to use it.

Testing will need to include:

  • Running example TWA visualisations to test that existing functionality is maintained.
  • Running the CReDo visualisations from that project's dev-vf-migrate branch to ensure the generic image can handle scenarios correctly.
  • Review new docs/credo.md file.

dev-credo-merge: Added support for scenario selection, and a (hopeful…
5650c21 
…ly temporary) "credo" mode to support its differing URL format for meta/time queries.
@mdhillman mdhillman added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request infra-vis Infrastructure issues relating to the visualisation framework. infra General infrastructure issues for to the base library, agent framework, stack, vis tools etc. labels Dec 20, 2023
@mdhillman mdhillman self-assigned this Dec 20, 2023
@mdhillman mdhillman mentioned this pull request Dec 20, 2023
Open
@mdhillman mdhillman changed the title dev-credo-merge: dev-credo-merge Dec 20, 2023
cmclscourtney
cmclscourtney approved these changes Jan 2, 2024
View reviewed changes
Copy link
Collaborator

@cmclscourtney cmclscourtney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested examples and CReDo and all works well

@mdhillman mdhillman merged commit 9776ec4 into main Jan 2, 2024
1 check passed
@mdhillman mdhillman deleted the dev-credo-merge branch January 2, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmclscourtney cmclscourtney cmclscourtney approved these changes

@gpeb2 gpeb2 Awaiting requested review from gpeb2

Assignees

@mdhillman mdhillman

Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request infra General infrastructure issues for to the base library, agent framework, stack, vis tools etc. infra-vis Infrastructure issues relating to the visualisation framework.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdhillman @cmclscourtney