Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various style improvements #1069

Merged
merged 13 commits into from
Jan 12, 2024
Merged

Various style improvements #1069

merged 13 commits into from
Jan 12, 2024

Conversation

Ushcode
Copy link
Collaborator

@Ushcode Ushcode commented Jan 11, 2024

The main stylesheet for the twa-vf was updated to add

  • More interesting link hover behaviour in #sidePanelLinks
  • CMCL blue colour integration in side panel
  • 3D shadowing for side panel to appear above map container
  • Dynamic wave animation in Side Panel
  • White backgrounds changed to an off white, black text changed to a dark grey.

Note

I took these two colours from the GitHub light theme, and so are definitely WCAG compliant

Copy link
Collaborator Author

@Ushcode Ushcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

twa-vf build version number is 4.3.1-COLORS-SNAPSHOT

@Ushcode Ushcode requested a review from mdhillman January 11, 2024 12:20
@Ushcode
Copy link
Collaborator Author

Ushcode commented Jan 11, 2024

image

Should look like this ↑

Used to look like this ↓

image

Copy link
Collaborator

@mdhillman mdhillman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed changes with @Ushcode, all looks okay.

@Ushcode Ushcode merged commit 06ce8c1 into main Jan 12, 2024
1 check passed
@Ushcode Ushcode deleted the Ushcode/issue908 branch January 12, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants