-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add escape / close button to scenario selector #1178
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On my machine the scenario-header
seems to overlap with the scenario-close
button, see image. I've also made a minor point about code formatting.
Also would it be possible to either highlight the current scenario and/or make it clickable? I think adding a call to the close function when the scenario ID matches the current one, rather than just return
would be enough. Or even just removing that condition all together.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On my machine the
scenario-header
seems to overlap with thescenario-close
button, see image. I've also made a minor point about code formatting.
Fixed this.
Code should be there to show currently selected scenario in a darker colour but only one scenario currently up on hobbes to test
Clicking on the current scenario in the scenario selector now reloads the scenario rather than doing nothing.
There is now a small x in the top right of the scenario selector
esc
key