Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add escape / close button to scenario selector #1178

Merged
merged 15 commits into from
Apr 30, 2024
Merged

Conversation

Ushcode
Copy link
Collaborator

@Ushcode Ushcode commented Apr 26, 2024

There is now a small x in the top right of the scenario selector

  • This will only show up if a scenario has been selected at least once (so you can't skip it and have a map with no data)
  • Also works to hit the esc key
  • confirm px height of footer
  • scenario escape

@Ushcode Ushcode requested review from cmclscourtney and gpeb2 April 26, 2024 15:07
Copy link
Collaborator

@gpeb2 gpeb2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On my machine the scenario-header seems to overlap with the scenario-close button, see image. I've also made a minor point about code formatting.
Also would it be possible to either highlight the current scenario and/or make it clickable? I think adding a call to the close function when the scenario ID matches the current one, rather than just return would be enough. Or even just removing that condition all together.
image

@gpeb2 gpeb2 self-requested a review April 26, 2024 16:37
Copy link
Collaborator Author

@Ushcode Ushcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On my machine the scenario-header seems to overlap with the scenario-close button, see image. I've also made a minor point about code formatting.
Fixed this.

Code should be there to show currently selected scenario in a darker colour but only one scenario currently up on hobbes to test

Ushcode and others added 3 commits April 29, 2024 12:16
Clicking on the current scenario in the scenario selector now reloads the scenario rather than doing nothing.
@Ushcode Ushcode merged commit dc33b92 into main Apr 30, 2024
1 check passed
@Ushcode Ushcode deleted the dev-op-scenariochanger branch April 30, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants