Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Workforce #713

Merged
merged 46 commits into from
Aug 7, 2024
Merged

feat: Add Workforce #713

merged 46 commits into from
Aug 7, 2024

Conversation

yiyiyi0817
Copy link
Member

@yiyiyi0817 yiyiyi0817 commented Jul 8, 2024

Description

Consider one layer structure first, big workforce containing small leaf workforces + agents.

Motivation and Context

A workflow/workforce for task completing.

  1. Workforce(task="Human Task",society=[Agent A, Agent B, RolePlaying …..],manager_agent_config={…},
    task_agent_config={…},… workforce = [], description=”xx”)→ ChatResult & Message
  2. Guohao: Workforce(task=””, workforce=[workforce, …])
  3. Agents in Workforce
    1. Manager Agent(optional): track task and can create new agent
    2. Task Agent(optional): Specify, Spilt, Generate, Plan tasks, already supported in CAMEL
    3. Critic Agent(optional): Assists in selecting an option, already supported in CAMEL
  4. Flow in Workforce
    1. Human Task → Task A, Task B, Task C (Message) by Task Agent

    2. Manager Agent initialize the first round task assignment

      Task A -> Agent A (model=Model A, tool=[T1, T2],knowledgebase=[KB1, KB2])
      Task B -> Agent B (model=Model B, tool=[T1, T3, T5],knowledgebase=[KB2, KB3, KB4])
      Task C ....

    3. environment for Agent A = related tasks information + all agents information
      environment for Manager Agent = all tasks information + all agents information

    4. If Agent A can solve task A, CAMEL Task A done, back to Manager Agent.

      If Agent A can’t solve task A, Agent A will ask Task Agent split Task A, make it into Task A.1, Task A.2…, from Agent A’s environment information, Agent A find another agent can solve Task A.1, send message to that Agent, assign Task A.1, once finished ,back to Manager Agent.

      Society pipeline? sequential, hierarchical, star, or other topology..

      Task A.1 → Workforce with 3 agents

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of example)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.

@yiyiyi0817 yiyiyi0817 self-assigned this Jul 8, 2024
Copy link

coderabbitai bot commented Jul 8, 2024

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@yiyiyi0817 yiyiyi0817 added this to the Sprint 7 milestone Jul 8, 2024
@yiyiyi0817 yiyiyi0817 linked an issue Jul 8, 2024 that may be closed by this pull request
2 tasks
@Appointat Appointat marked this pull request as draft July 9, 2024 07:57
camel/tasks/task.py Outdated Show resolved Hide resolved
camel/tasks/task.py Outdated Show resolved Hide resolved
camel/utils/channel.py Outdated Show resolved Hide resolved
Copy link
Member Author

@yiyiyi0817 yiyiyi0817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for review.

camel/tasks/task.py Show resolved Hide resolved
camel/tasks/task.py Outdated Show resolved Hide resolved
camel/tasks/task.py Outdated Show resolved Hide resolved
camel/utils/channel.py Outdated Show resolved Hide resolved
examples/workforce/workforce.py Outdated Show resolved Hide resolved
Copy link
Member

@Wendong-Fan Wendong-Fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yiyiyi0817 and @WHALEEYE !

The current implementation is task-solving oriented, I think in the long term we also need to support multi-agent communication for society simulation, like agents doing debate, we can explore this part later.

I feel it's not so necessary to set role_playing_workforce and single_agent_workforce just to convert roleplaying/agent into workforce, from user's side it's also complex to set up one workforce flow with current design, can we allow user input their agent, roleplaying, workforce objs directly into child_workforces list and do the transfer internally? WDYT?

camel/workforce/internal_workforce.py Outdated Show resolved Hide resolved
camel/workforce/internal_workforce.py Outdated Show resolved Hide resolved
camel/workforce/internal_workforce.py Outdated Show resolved Hide resolved
camel/workforce/internal_workforce.py Outdated Show resolved Hide resolved
camel/workforce/internal_workforce.py Outdated Show resolved Hide resolved
camel/workforce/internal_workforce.py Outdated Show resolved Hide resolved
camel/workforce/leaf_workforce.py Outdated Show resolved Hide resolved
camel/workforce/workforce_prompt.py Show resolved Hide resolved
@yiyiyi0817 yiyiyi0817 changed the title [Draft] [No Need to be Merged] Architecture of Workforce feat: Add Workforce Jul 29, 2024
Copy link
Member Author

@yiyiyi0817 yiyiyi0817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your review! @Wendong-Fan

camel/workforce/internal_workforce.py Outdated Show resolved Hide resolved
camel/workforce/leaf_workforce.py Outdated Show resolved Hide resolved
camel/workforce/workforce_prompt.py Show resolved Hide resolved
@WHALEEYE WHALEEYE marked this pull request as ready for review August 1, 2024 15:26
@Appointat
Copy link
Member

I helped resolve the conflicts in the pr withe master branch, including the issue of docstring format and pytest example.

Copy link
Member

@Wendong-Fan Wendong-Fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can temporarily merge this PR and to the enhance further for the 2nd version as described here: #796
The compose method of Task also need to be improved

@Wendong-Fan Wendong-Fan merged commit e3b94a0 into master Aug 7, 2024
6 checks passed
@Wendong-Fan Wendong-Fan deleted the group_chat_architecture branch August 7, 2024 09:36
@WHALEEYE WHALEEYE mentioned this pull request Aug 30, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Developing
Development

Successfully merging this pull request may close these issues.

[Feature Request] Multi agent Workforce
6 participants