Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define validator for old schema #112

Merged

Conversation

YashKumarVerma
Copy link
Contributor

Summary

  • defines a validator to check the routes.json file.
  • will throw error if file does not match the given schema

Motivation

Testing

  • manual
  • unit tests in follow-up.

Questions

  • N/A

@birm birm self-requested a review June 24, 2021 19:19
@birm
Copy link
Member

birm commented Jun 25, 2021

I'm having a hard time getting docker compose to accept your branch name, presumably due to the slashes?
Slashes aren't common, but certainly aren't strange in branch names, so I'm sure there's some escape sequence or something.
If you know how to add your branch name to the context line, please let me know. Otherwise, I'll just clone first and build from that.

@YashKumarVerma
Copy link
Contributor Author

I'm having a hard time getting docker compose to accept your branch name, presumably due to the slashes?
Slashes aren't common, but certainly aren't strange in branch names, so I'm sure there's some escape sequence or something.
If you know how to add your branch name to the context line, please let me know. Otherwise, I'll just clone first and build from that.

I'm not sure how to do that, I'll take care in further PRs to avoid slashes in branch names

@birm birm merged commit 670fe3f into camicroscope:develop Jun 29, 2021
This was referenced Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants