Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Tooltip Inaccessible on Hover in Annotation Assistant (#994) #1041

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

rajku-dev
Copy link

Fixes #994

Explanation of Changes

  • interactive: true: Keeps the tooltip open when hovering over the tooltip itself, so it doesn't disappear immediately. This fixes the issue where the tooltip would disappear before users can interact with it.
  • trigger: 'mouseenter focus': Ensures the tooltip activates on both mouse hover and keyboard focus, making it accessible for keyboard users and screen readers.
  • aria configuration: Setting aria: { content: 'describedby' } links the tooltip to the label for screen readers, providing a description of the label's purpose.

This configuration help ensure tooltip remains visible when needed and is fully accessible for all users, including those who rely on screen readers.

@nwanduka
Copy link
Contributor

Thanks for jumping in to fix this @rajku-dev. Well done. While we wait for @birm to review the changes, could you change the base branch from master to develop? And for subsequent PRs, develop should be the base branch.

@rajku-dev rajku-dev changed the base branch from master to develop November 15, 2024 13:21
@rajku-dev
Copy link
Author

Thanks for jumping in to fix this @rajku-dev. Well done. While we wait for @birm to review the changes, could you change the base branch from master to develop? And for subsequent PRs, develop should be the base branch.

I've updated the base branch to develop as requested. Let me know if there's anything else I need to adjust

Copy link
Member

@birm birm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely, good fixes. Thank you :)

@birm birm merged commit b55dfc7 into camicroscope:develop Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Accessibility] Slide Viewer: Tooltip inaccessible on hover
3 participants