Drop old storage engine from code base #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tore a stub for now (still tracks references).
has the beneficial side-effect of removing the include order dependency between platforms/unix/common.h and misc/messaging_interface.h.
via storage engine.
|
@ICGog Please review. |
| pid_file << getpid(); | ||
| pid_file.close(); | ||
| FILE* pid_file; | ||
| pid_file = fopen(pid_filename.c_str(), "w"); |
There was a problem hiding this comment.
Maybe check if fopen failed or not. (This is also a test comment:) ).
There was a problem hiding this comment.
Addressed in f3883b6. 👍
|
|
ms705
added a commit
that referenced
this pull request
May 20, 2015
Drop old storage engine from code base.
shivramsrivastava
added a commit
to shivramsrivastava/firmament
that referenced
this pull request
Nov 16, 2018
…eature Gang scheduling feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes the old (incomplete and never fully working) in-memory storage engine from the code base. We don't need it any more, and will replace it with different plugins for different use cases:
There is no functional impact from this change; I'm merely dropping dead code (and am fixing up a few nasty include order dependencies along the way).
