[HOLD] Spike: link-checking with excluded versions #1675
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE!!!
Part of #1659
Questions answered
No, it will not pass. Here is a build of only the latest versions, and here is a build of only older versions. (see commits 1 and 2 in this PR.)
Not likely, because we also check product-links.txt, and that also includes a bunch of URLs.
It might pass if the build includes the current version, too.
This workflow demonstrates that a build that includes the next, current, and one old version will pass when it is link-checked for only the next, current, and one old version URLs. (see commits 3 and 4 in this PR.)
Lots of connection errors: see this one and that one.
There is actually a flag we can pass to the link-checking tool to report connection failures as warnings instead of errors. I've PR'ed a change for this at ci(linkcheck): use github action instead of downloading tar, and ignore connection failures for cron-based workflow #1676.