Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct usage of custom heading IDs #4946

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Conversation

pepopowitz
Copy link
Collaborator

@pepopowitz pepopowitz commented Feb 6, 2025

❗ This resolves a build error on main.

Description

Fixes a build error from usage of unescaped { in text. This wasn't a problem before #4799 merged, and I forgot to update that branch from main before I merged it, so I didn't find it until publish_stage was broken on main. 😅

Adjusts the links to follow the docusaurus guidance.

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support. (add bug or support label)
  • This is already available but undocumented and should be released within a week. (add available & undocumented label)
  • This is on a specific schedule and the assignee will coordinate a release with the DevEx team. (create draft PR and/or add hold label)
  • This is part of a scheduled alpha or minor. (add alpha or minor label)
  • There is no urgency with this change (add low prio label)

PR Checklist

  • My changes are for the next minor and are in /docs directory (aka /next/).
  • My changes are for an already released minor and are in /versioned_docs directory.

@pepopowitz pepopowitz self-assigned this Feb 6, 2025
@pepopowitz pepopowitz added the kind/bug Issues related with bugs in the documentation label Feb 6, 2025
Copy link
Contributor

github-actions bot commented Feb 6, 2025

👋 🤖 🤔 Hello, @pepopowitz! Did you make your changes in all the right places?

These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.6/.

  • docs/reference/announcements/870.md

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

@pepopowitz pepopowitz requested a review from akeller February 6, 2025 16:53
@pepopowitz pepopowitz enabled auto-merge (squash) February 6, 2025 16:56
Copy link
Contributor

@mesellings mesellings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved in principle, good catch, but I think @wollefitz should approve 👍

@pepopowitz pepopowitz merged commit 9a67f3a into main Feb 6, 2025
14 checks passed
@pepopowitz pepopowitz deleted the pepopowitz/d3-fallout branch February 6, 2025 17:05
@pepopowitz
Copy link
Collaborator Author

In the interest of fixing main, I auto-merged this. If there is more feedback, I'll address it in a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Issues related with bugs in the documentation
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants