Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WASM: Temporarily rollback on wasm-opt dependency for release builds to make it work on some LG + Samsung TVs #1372

Merged
merged 1 commit into from
Feb 5, 2024
Merged

WASM: Temporarily rollback on wasm-opt dependency for release builds to make it work on some LG + Samsung TVs #1372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,6 @@
"@typescript-eslint/parser": "6.16.0",
"arraybuffer-loader": "1.0.8",
"babel-loader": "9.1.3",
"binaryen": "116.0.0",
"chai": "4.3.10",
"core-js": "3.34.0",
"esbuild": "0.19.10",
Expand Down
63 changes: 0 additions & 63 deletions scripts/wasm-optimize.mjs
View file
Open in desktop

This file was deleted.

11 changes: 7 additions & 4 deletions src/parsers/manifest/dash/wasm-parser/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,12 +251,13 @@ fear that they may change in the future, in which case this documentation could
easily be outdated.

To be able to call those scripts, you will need to have the Rust compiler
toolchain installed and ready to compile to WebAssembly.
toolchain installed and ready to compile to WebAssembly as well as `binaryen`, a
WebAssembly-specialized toolbox.

To do this, the easiest way would be to rely on `rustup`, a tool to install and
update Rust toolchains:
There are several ways this can be done, with the easiest way generally being:

1. Install [rustup](https://rustup.rs/)
1. Install [rustup](https://rustup.rs/), which is a tool intended to
facilitate the installation of Rust toolchains

2. Install and rely on the stable toolchain:
```sh
Expand All @@ -268,4 +269,6 @@ update Rust toolchains:
rustup target add wasm32-unknown-unknown
```

4. Now install [binaryen](https://github.com/WebAssembly/binaryen)

That should be it!
Loading