Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use preferred formats for MappableConcept.mappings #383

Closed
korikuzma opened this issue Dec 24, 2024 · 3 comments · Fixed by #386 or #390
Closed

Use preferred formats for MappableConcept.mappings #383

korikuzma opened this issue Dec 24, 2024 · 3 comments · Fixed by #386 or #390
Assignees
Labels
enhancement New feature or request priority:high High priority

Comments

@korikuzma
Copy link
Member

Feature description

Use the preferred Coding format for each item in MappableConcept.mappings. A Coding consists of a relation and coding, where a Coding requires:

  • code: "A symbol uniquely identifying the concept, as in a syntax defined by the code system. CURIE format is preferred where possible (e.g. 'SO:0000704' is the CURIE form of the Sequence Ontology code for 'gene')."
  • system: description": "The terminology/code system that defined the code. May be reported as a free-text name (e.g. 'Sequence Ontology'), but it is preferable to provide a uri/url for the system. When the 'code' is reported as a CURIE, the 'system' should be reported as the uri that the CURIE's prefix expands to (e.g. 'http://purl.obofoundry.org/so.owl/' for the Sequence Ontology)."

Use case

The Coding object allows for flexibility in how system and code are represented, which can lead to inconsistency across different implementations and systems. Aligning these fields to use preferred formats can help ensure consistent representation.

Acceptance Criteria

Given a Mappable Concept (gene) is queried,
When it has mappings,
Then the system must be represented as a URI/URL and the code must be represented as a CURIE, where possible

Proposed solution

No response

Alternatives considered

No response

Implementation details

No response

Potential Impact

No response

Additional context

No response

Contribution

Yes, I can create a PR for this feature.

@korikuzma korikuzma added enhancement New feature or request priority:high High priority labels Dec 24, 2024
@korikuzma korikuzma self-assigned this Dec 24, 2024
@jsstevenson
Copy link
Member

Might be a nice time to refactor the other (non-normalized) response objects into GKS as well. We'd talked about this a long time ago but never got around to it.

@korikuzma
Copy link
Member Author

korikuzma commented Dec 24, 2024

@jsstevenson ya, I don't think that's as big of a priority though (at least for VarCat / MetaKB / BMK, since we only use /normalize). Issue is #251

korikuzma added a commit that referenced this issue Dec 26, 2024
close #383

* use preferred format (URI) for `system`, where possible
korikuzma added a commit that referenced this issue Dec 27, 2024
close #383

* use preferred format (URI) for `system`, where possible
@korikuzma
Copy link
Member Author

So #386 actually really only focused on the system part. Going to create a new PR for using CURIEs for code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority:high High priority
Projects
None yet
2 participants