-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use preferred formats for MappableConcept.mappings
#383
Comments
Might be a nice time to refactor the other (non-normalized) response objects into GKS as well. We'd talked about this a long time ago but never got around to it. |
@jsstevenson ya, I don't think that's as big of a priority though (at least for VarCat / MetaKB / BMK, since we only use |
close #383 * use preferred format (URI) for `system`, where possible
close #383 * use preferred format (URI) for `system`, where possible
So #386 actually really only focused on the |
close #383 * Use `concept_id` as the CURIE
Feature description
Use the preferred
Coding
format for each item inMappableConcept.mappings
. ACoding
consists of arelation
andcoding
, where a Coding requires:code
: "A symbol uniquely identifying the concept, as in a syntax defined by the code system. CURIE format is preferred where possible (e.g. 'SO:0000704' is the CURIE form of the Sequence Ontology code for 'gene')."system
: description": "The terminology/code system that defined the code. May be reported as a free-text name (e.g. 'Sequence Ontology'), but it is preferable to provide a uri/url for the system. When the 'code' is reported as a CURIE, the 'system' should be reported as the uri that the CURIE's prefix expands to (e.g. 'http://purl.obofoundry.org/so.owl/' for the Sequence Ontology)."Use case
The
Coding
object allows for flexibility in howsystem
andcode
are represented, which can lead to inconsistency across different implementations and systems. Aligning these fields to use preferred formats can help ensure consistent representation.Acceptance Criteria
Given a Mappable Concept (gene) is queried,
When it has
mappings
,Then the
system
must be represented as a URI/URL and thecode
must be represented as a CURIE, where possibleProposed solution
No response
Alternatives considered
No response
Implementation details
No response
Potential Impact
No response
Additional context
No response
Contribution
Yes, I can create a PR for this feature.
The text was updated successfully, but these errors were encountered: