Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: xrefs should have exactMatch for ConceptMapping.relation #460

Merged
merged 9 commits into from
Jan 29, 2025
Merged

fix!: xrefs should have exactMatch for ConceptMapping.relation #460

merged 9 commits into from
Jan 29, 2025

Conversation

korikuzma
Copy link
Member

@korikuzma korikuzma commented Jan 28, 2025 •
edited
Loading

close #459

  • Mappings for indications will also have exactMatch

@korikuzma
fix!: use correct representation of Coding object in mappings
fb45c2b 
close #456

* `system` MUST use `iriReference`, not a free-text label
* `code` MUST use syntax defined by the `system`
* `id` will use record `concept_id`
@korikuzma
rename
6e18466
@korikuzma
use MappingProxyType
2abfffc
@korikuzma
update uniprot
08ced03
@korikuzma
update fixtures
31cf51e
@korikuzma
update
9ed3282
@korikuzma korikuzma added priority:medium Medium priority bug Something isn't working labels Jan 28, 2025
@korikuzma korikuzma self-assigned this Jan 28, 2025
@korikuzma korikuzma linked an issue Jan 29, 2025 that may be closed by this pull request
Sources we ingest should have exactMatch for ConceptMapping.relation #459
Closed
Base automatically changed from issue-456 to main January 29, 2025 21:13
@korikuzma korikuzma marked this pull request as ready for review January 29, 2025 21:16
@korikuzma korikuzma requested a review from jsstevenson January 29, 2025 21:16
@korikuzma korikuzma merged commit 724b29e into main Jan 29, 2025
15 checks passed
@korikuzma korikuzma deleted the issue-459 branch January 29, 2025 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsstevenson jsstevenson jsstevenson approved these changes

Assignees

@korikuzma korikuzma

Labels
bug Something isn't working priority:medium Medium priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sources we ingest should have exactMatch for ConceptMapping.relation
2 participants
@korikuzma @jsstevenson