Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve pydantic serializer warnings in _add_merged_meta #461

Merged
merged 1 commit into from
Jan 30, 2025
Merged

fix: resolve pydantic serializer warnings in _add_merged_meta #461

merged 1 commit into from
Jan 30, 2025

Conversation

korikuzma
Copy link
Member

close #458

  • source_meta key should have type SourceName not str

@korikuzma
fix: resolve pydantic serializer warnings in _add_merged_meta
b40d6d2 
close #458

* `source_meta` key should have type `SourceName` not `str`
@korikuzma korikuzma added priority:medium Medium priority bug Something isn't working labels Jan 30, 2025
@korikuzma korikuzma requested a review from jsstevenson January 30, 2025 18:52
@korikuzma korikuzma self-assigned this Jan 30, 2025
@korikuzma korikuzma merged commit 1493477 into main Jan 30, 2025
17 checks passed
@korikuzma korikuzma deleted the issue-458 branch January 30, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsstevenson jsstevenson jsstevenson approved these changes

Assignees

@korikuzma korikuzma

Labels
bug Something isn't working priority:medium Medium priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Getting Pydantic serializer warnings when running MetaKB tests
2 participants
@korikuzma @jsstevenson