Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CCT-71: Try to ping server, when --proxy is used #3347

Merged
merged 1 commit into from
Oct 25, 2023
Merged

CCT-71: Try to ping server, when --proxy is used #3347

merged 1 commit into from
Oct 25, 2023

Conversation

jirihnidek
Copy link
Contributor

  • When --proxy is used, then try to ping server before new configuration is used.

@jirihnidek
CCT-71: Try to ping server, when --proxy is used
a86ef54 
* When --proxy is used, then try to ping server before new
  configuration is used.
@cnsnyder cnsnyder requested review from a team and ptoscano and removed request for a team October 25, 2023 09:36
@github-actions
Copy link

Coverage

Coverage (computed on Fedora latest) •
FileStmtsMissCoverMissing
subscription_manager/cli_command
   cli.py2103185%65, 69, 124, 128–129, 144, 201, 205, 207, 250, 289, 300–302, 316–318, 341, 361, 387, 396–397, 401–402, 418, 420–421, 423–424, 429, 437
TOTAL18160456174% 

Tests Skipped Failures Errors Time
2640 9 💤 0 ❌ 0 🔥 1m 1s ⏱️

m-horky
m-horky approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@m-horky m-horky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@m-horky m-horky merged commit 65ab1a6 into main Oct 25, 2023
11 checks passed
@m-horky m-horky deleted the jhnidek/CCT-71 branch October 25, 2023 10:07
@ptoscano ptoscano mentioned this pull request Oct 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-horky m-horky m-horky approved these changes

@ptoscano ptoscano Awaiting requested review from ptoscano ptoscano was automatically assigned from candlepin/client-tools

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jirihnidek @m-horky