Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCT-118: Fix flake8 error E721 #3353

Merged
merged 1 commit into from
Nov 2, 2023
Merged

CCT-118: Fix flake8 error E721 #3353

merged 1 commit into from
Nov 2, 2023

Conversation

m-horky
Copy link
Contributor

@m-horky m-horky commented Nov 1, 2023

  • Card ID: CCT-118

E721: do not compare types, for exact checks use is / is not

@cnsnyder cnsnyder requested review from a team and jirihnidek and removed request for a team November 1, 2023 16:25
@m-horky m-horky force-pushed the mhorky/CCT-118_flake8-E721 branch from b110482 to f6f0407 Compare November 1, 2023 16:41
Copy link

github-actions bot commented Nov 1, 2023

Coverage

Coverage (computed on Fedora latest) •
FileStmtsMissCoverMissing
cloud_what/providers
   aws.py1844277%88, 103, 111, 148–149, 151–154, 156, 165, 168–169, 199, 203–204, 329, 390–391, 393–394, 396–400, 402–407, 409–413, 415–418, 424
   azure.py1384071%108, 134, 138, 179, 235–237, 261, 263, 265–266, 268–272, 274–279, 281–287, 290–291, 294, 297–303, 309
   gcp.py1483278%131, 146, 150, 225–226, 241, 247, 254, 262, 272, 351, 353, 355–356, 358–362, 364–370, 372–373, 375–377, 383
rhsmlib
   client_info.py351362%47–48, 58–61, 63–64, 71–72, 74–75, 82
subscription_manager
   productid.py3544587%135, 247, 250, 278, 285, 291, 323, 327, 341, 343–344, 359, 361–362, 366–367, 698–700, 704, 709–710, 715–717, 722, 725–726, 748–749, 751–758, 760, 764, 766, 768–769, 771–772
syspurpose
   files.py3762792%99, 103–104, 108–109, 163, 205, 218, 363, 367, 431, 435, 504–506, 566–567, 569–570, 601, 623–624, 644–646, 667–668
TOTAL18160455674% 

Tests Skipped Failures Errors Time
2640 9 💤 0 ❌ 0 🔥 1m 5s ⏱️

* Card ID: CCT-118

E721: do not compare types, for exact checks use `is` / `is not`
@ptoscano ptoscano force-pushed the mhorky/CCT-118_flake8-E721 branch from f6f0407 to 5f6c10b Compare November 2, 2023 17:14
@ptoscano ptoscano merged commit 55e56fd into main Nov 2, 2023
10 checks passed
@ptoscano ptoscano deleted the mhorky/CCT-118_flake8-E721 branch November 2, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants