Small fixes of libdnf plugins #3382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jirihnidek
commented
Feb 22, 2024
jirihnidek
commented
- Removed unused includes of .h files
- Fixed deprecated function prototype
- Fixed few memory leaks in productdb.c
- Fixed few memory leaks in test-productdb.c
cnsnyder
requested review from
a team and
wottop
and removed request for
a team
Coverage (computed on Fedora latest) •
|
ptoscano
requested changes
Feb 26, 2024
* There were some unused includes in product-id.c and unit test files
* Added void to prototype of initRepoProductId()
* When reading of JSON file fails, then do not forget to free object representing JSON file. Fix indentation.
* Fixed several memory leaks in test-productdb.c
jirihnidek
force-pushed
the
jhnidek/libdnf_small_fixes
branch
from
b137fdc to
01f65d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.