feat: Added zone GCP fact #3388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jirihnidek
commented
Apr 9, 2024
jirihnidek
commented
- Added fact about zone, where the instance is located
- Extended unit test covering this new fact
- Note: GCP does not provide any information about instance type
cnsnyder
requested review from
a team and
DuckBoss
and removed request for
a team
ptoscano
force-pushed
the
jhnidek/gcp_region_fact
branch
from
4587eb1 to
01bd67d
Compare
* Added fact about zone, where the instance is located * Extended unit test covering this new fact * Note: GCP does not provide any information about instance type
jirihnidek
force-pushed
the
jhnidek/gcp_region_fact
branch
from
01bd67d to
2d04f77
Compare
ptoscano
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.