feat: 1.28 Added more AWS cloud facts #3390

jirihnidek · 2024-04-23T13:46:02Z

Backport to 1.28 branch
Original PR: feat: Added more AWS cloud facts #3387
- Original commit: df5776a
Card Id: CCT-366
Added two options "aws_region" and "aws_instance_type" to cloud facts to be able to provide better business intelligence
Extended unit tests

* Backport to 1.28 branch * Original PR: #3387 * Original commit: df5776a * Card Id: CCT-366 * Added two options "aws_region" and "aws_instance_type" to cloud facts to be able to provide better business intelligence * Extended unit tests

github-actions · 2024-04-23T13:48:13Z

Coverage (computed on CentOS Stream 9) •

File	Stmts	Miss	Cover	Missing
rhsmlib/facts
cloud_facts.py	87	8	90%	94, 99, 103, 161, 167, 172, 177, 179
TOTAL	22297	9256	58%

Tests	Skipped	Failures	Errors	Time
2368	11 💤	0 ❌	0 🔥	44.096s ⏱️

m-horky

LGTM

feat: 1.28 Added more AWS cloud facts

754846c

* Backport to 1.28 branch * Original PR: #3387 * Original commit: df5776a * Card Id: CCT-366 * Added two options "aws_region" and "aws_instance_type" to cloud facts to be able to provide better business intelligence * Extended unit tests

m-horky approved these changes May 14, 2024

View reviewed changes

m-horky merged commit 7cf5af5 into subscription-manager-1.28 May 14, 2024
10 of 11 checks passed

m-horky deleted the jhnidek/1.28_cct-366_more_aws_facts branch May 14, 2024 10:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: 1.28 Added more AWS cloud facts #3390

feat: 1.28 Added more AWS cloud facts #3390

jirihnidek commented Apr 23, 2024

github-actions bot commented Apr 23, 2024

m-horky left a comment

feat: 1.28 Added more AWS cloud facts #3390

feat: 1.28 Added more AWS cloud facts #3390

Conversation

jirihnidek commented Apr 23, 2024

github-actions bot commented Apr 23, 2024

m-horky left a comment

Choose a reason for hiding this comment