Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jhnidek/1.28 cct 384 more azure facts #3393

Merged
merged 3 commits into from
May 14, 2024
Merged

Jhnidek/1.28 cct 384 more azure facts #3393

merged 3 commits into from
May 14, 2024

Conversation

jirihnidek
Copy link
Contributor

  • Backport PR to 1.28 branch
  • Original PR: feat: Added Azure location to facts #3389
  • Card ID: CCT-384
  • Add azure_location to facts, when available
  • Updated the version of metadata we try to get from Azure IMDS server, because we need facts from new
    version of metadata and old version of metadata could be deprecated in the future
  • Added new facts from Azure IMDS metadata available since 2021-03-01
    Metadata with given version provides extendedLocation.name and extendedLocation.type
  • Extended unit tests to include new facts

@jirihnidek
feat: 1.28 Added Azure location to facts
7ed2d4a 
* Backport commit to 1.28 branch
* Original PR: #3389
  * Original commit: c9acace
* Card ID: CCT-384
* Add azure_location to facts, when available
* TODO: update required version of metadata and get extended
  locatition fact
@jirihnidek
fix: 1.28 Update version of Azure metadata
1953963 
* Backport commit to 1.28 branch
* Original PR: #3389
  * Original commit: 76253dc
* Update the version of metadata we try to get from
  Azure IMDS server, because we need facts from new
  version of metadata and old version of metadata
  could be deprecated in the future
@jirihnidek
feat: 1.28 Azure: added extended location and type of location fact
c51eae7 
* Backport commit to 1.28
* Original PR: #3389
  * Original commit: 0bba05e
* Card ID: CCT-384
* Added new facts from Azure IMDS metadata available since
  2021-03-01
  * Metadata with given version provides extendedLocation.name
    and extendedLocation.type
* Extendd unit tests to include new facts
@github-actions GitHub Actions
Copy link

Coverage

Coverage (computed on CentOS Stream 9) •
FileStmtsMissCoverMissing
cloud_what/providers
   azure.py1384170%132, 136, 149–150, 177, 232–234, 258, 260, 262–263, 265–269, 271–276, 278–284, 287–288, 290, 292–298, 304
rhsmlib/facts
   cloud_facts.py90891%94, 99, 103, 163, 169, 174, 179, 181
TOTAL22300925858% 

Tests Skipped Failures Errors Time
2368 11 💤 0 ❌ 0 🔥 43.443s ⏱️

m-horky
m-horky approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@m-horky m-horky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@m-horky m-horky merged commit e7ac53e into subscription-manager-1.28 May 14, 2024
8 of 11 checks passed
@m-horky m-horky deleted the jhnidek/1.28_cct-384_more_azure_facts branch May 14, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-horky m-horky m-horky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jirihnidek @m-horky