fix: 1.29 Do not try to test this branch on Fedora rawhide #3396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jirihnidek
commented
May 20, 2024
jirihnidek
commented
- This branch is intended only for RHEL 9. It does not make sense to try to test this for Fedora rawhide, which contains too many things not compatible with RHEL 9
cnsnyder
requested review from
a team and
ptoscano
and removed request for
a team
|
Please drop also "fedora latest", as it is in the same situation as fedora rawhide. |
It is not in the same situation, but we will be there sooner or later... So, I will drop it too. I would like to solve failing unit tests first. |
|
Is this PR supposed to be targeting 1.29 instead of main? Also, seems like 1.29.40 needs the same patch. |
#3405 did it. |
|
Also, once done please backport it to the |
* This branch is intended only for RHEL 9. It does not make sense to try to test this for Fedora rawhide, which contains too many things not compatible with RHEL 9
jirihnidek
force-pushed
the
jhnidek/1.29_fix_build
branch
from
f4d57c5 to
a5c4f33
Compare
* This branch is intended only for RHEL 9. It does not make sense to try to test this for Fedora latest, because this branch becomes incompatible with the latest Fedora sooner or later.
jirihnidek
force-pushed
the
jhnidek/1.29_fix_build
branch
from
a5c4f33 to
3510d47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.