Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Hide subscription management "errors" in container mode #3397

Merged
merged 1 commit into from
May 30, 2024

Conversation

m-horky
Copy link
Contributor

@m-horky m-horky commented May 21, 2024

  • Card ID: CCT-322
  • Card ID: RHEL-7199

When dnf is run in a container that gets its content from a host, extra messages were displayed:

- Updating Subscription Management repositories.
> Unable to read consumer identity
- subscription-manager is operating in container mode.
> This system is not registered with an entitlement server. You can use
  subscription-manager to register.

Only the first line and third should be displayed; the second and fourth are not relevant in container mode.

@cnsnyder cnsnyder requested review from a team and cnsnyder and removed request for a team May 21, 2024 09:50
@m-horky m-horky marked this pull request as draft May 21, 2024 17:15
* Card ID: CCT-322
* Card ID: RHEL-7199

When `dnf` is run in a container that gets its content from a host,
extra messages were displayed:

- Updating Subscription Management repositories.
> Unable to read consumer identity
- subscription-manager is operating in container mode.
> This system is not registered with an entitlement server. You can use
  subscription-manager to register.

Only the first line and third should be displayed; the second and fourth
are not relevant in container mode.
@m-horky m-horky force-pushed the mhorky/cct-322-dnf-in-container branch from d2dd29a to a3265e4 Compare May 22, 2024 08:20
Copy link

Coverage

Coverage (computed on Fedora latest) •
FileStmtsMissCoverMissing
TOTAL18405469674% 
report-only-changed-files is enabled. No files were changed during this commit :)

Tests Skipped Failures Errors Time
2647 14 💤 0 ❌ 0 🔥 36.060s ⏱️

Copy link
Contributor

@jirihnidek jirihnidek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@m-horky m-horky marked this pull request as ready for review May 22, 2024 10:46
@cnsnyder cnsnyder requested a review from a team May 22, 2024 10:46
@jirihnidek jirihnidek merged commit 0de0c38 into main May 30, 2024
28 checks passed
@jirihnidek jirihnidek deleted the mhorky/cct-322-dnf-in-container branch May 30, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants