Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.28] fix: Hide subscription management "errors" in container mode #3399

Merged

Conversation

m-horky
Copy link
Contributor

@m-horky m-horky commented May 21, 2024

  • Card ID: CCT-322
  • Card ID: RHEL-7199

When dnf is run in a container that gets its content from a host, extra messages were displayed:

- Updating Subscription Management repositories.
> Unable to read consumer identity
- subscription-manager is operating in container mode.
> This system is not registered with an entitlement server. You can use
  subscription-manager to register.

Only the first line and third should be displayed; the second and fourth are not relevant in container mode.

Copy link

github-actions bot commented May 21, 2024

Coverage

Coverage (computed on CentOS Stream 9) •
FileStmtsMissCoverMissing
TOTAL22298925958% 
report-only-changed-files is enabled. No files were changed during this commit :)

Tests Skipped Failures Errors Time
2368 11 💤 0 ❌ 0 🔥 42.469s ⏱️

@m-horky m-horky marked this pull request as draft May 21, 2024 17:14
@jirihnidek
Copy link
Contributor

@m-horky can you please convert this draft to the PR ready for review? Or is there anything blocking this draft?

* Card ID: CCT-322
* Card ID: RHEL-7199

When `dnf` is run in a container that gets its content from a host,
extra messages were displayed:

- Updating Subscription Management repositories.
> Unable to read consumer identity
- subscription-manager is operating in container mode.
> This system is not registered with an entitlement server. You can use
  subscription-manager to register.

Only the first line and third should be displayed; the second and fourth
are not relevant in container mode.

(Cherry-picked from a3265e4)
@m-horky m-horky force-pushed the mhorky/cct-233-dnf-in-container-1.28 branch from e950c9f to ea260cd Compare May 31, 2024 07:42
@m-horky
Copy link
Contributor Author

m-horky commented May 31, 2024

@jirihnidek Initially I wanted to wait for merge into main, so I had the commit hash to reference against.

@m-horky m-horky marked this pull request as ready for review May 31, 2024 07:43
Copy link
Contributor

@jirihnidek jirihnidek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jirihnidek jirihnidek merged commit 7405993 into subscription-manager-1.28 May 31, 2024
7 of 11 checks passed
@jirihnidek jirihnidek deleted the mhorky/cct-233-dnf-in-container-1.28 branch May 31, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants