Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 1.29 Deprecate redeem sub-command #3408

Merged

Conversation

jirihnidek
Copy link
Contributor

@jirihnidek jirihnidek commented May 31, 2024

  • Card ID: CCT-400
  • Modified short description of command
  • Modified description in manual page of subscription-manager
  • Information about "remove" command introduced in this commit:
    ceacba0 wasn't 100% correct.
    This should fix this issue.

@jirihnidek jirihnidek marked this pull request as draft May 31, 2024 15:57
@cnsnyder cnsnyder requested review from a team and ptoscano and removed request for a team May 31, 2024 15:57
@jirihnidek jirihnidek force-pushed the jhnidek/1.29_deprecate_redeem_command branch 2 times, most recently from 50d7d6e to aa3d1c4 Compare May 31, 2024 16:05
@jirihnidek jirihnidek force-pushed the jhnidek/1.29_deprecate_redeem_command branch 2 times, most recently from 834087a to 0c5bc47 Compare June 11, 2024 14:01
@jirihnidek jirihnidek marked this pull request as ready for review June 11, 2024 14:03
@cnsnyder cnsnyder requested a review from a team June 11, 2024 14:03
* Card ID: CCT-400
* Modified short description of command
* Modified description in manual page of subscription-manager
* Information about "remove" command introduced in this commit:
  ceacba0 wasn't 100% correct.
  This should fix this issue.
@jirihnidek jirihnidek force-pushed the jhnidek/1.29_deprecate_redeem_command branch from 0c5bc47 to 7834cb4 Compare June 11, 2024 14:04
Copy link
Contributor

@DuckBoss DuckBoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM 👍

@DuckBoss DuckBoss merged commit 9f25abf into subscription-manager-1.29 Jun 14, 2024
4 checks passed
@ptoscano ptoscano deleted the jhnidek/1.29_deprecate_redeem_command branch October 7, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants