fix: Create consumer cert & key, when chown failed #3466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jirihnidek
commented
Oct 18, 2024
jirihnidek
commented
- When it wasn't possible to change group of consumer key.pem, due to missing SELinux rule, then consumer cert.pem was not created. rhsm.service should write only error log message to rhsm.log in this case
* When it wasn't possible to change group of consumer key.pem, due to missing SELinux rule, then consumer cert.pem was not created. rhsm.service should write only error log message to rhsm.log in this case
cnsnyder
requested review from
a team and
ptoscano
and removed request for
a team
Coverage (computed on Fedora latest) •
|
||||||||||||||||||||||||||||||
ptoscano
requested changes
Oct 23, 2024
Comment on lines
+130
to
+136
| # Changing of owner can fail due to e.g. SELinux. When this | ||
| # operation fails, then we should only write error message, | ||
| # and we should create consumer cert.pem too | ||
| try: | ||
| os.chown(self.keypath(), 0, rhsm_group.gr_gid) | ||
| except OSError as err: | ||
| log.error(f"Unable to chown permissions of {self.keypath()}: {err}") |
There was a problem hiding this comment.
worth to factorize this to a small helper, as it is used in two places
| try: | ||
| os.chown(self.keypath(), 0, rhsm_group.gr_gid) | ||
| except OSError as err: | ||
| log.error(f"Unable to chown permissions of {self.keypath()}: {err}") | ||
| os.chmod(self.keypath(), managerlib.ID_CERT_PERMS) |
There was a problem hiding this comment.
# Expected permissions for identity certificates:
ID_CERT_PERMS: int = stat.S_IRUSR | stat.S_IWUSR | stat.S_IRGRPconsidering ID_CERT_PERMS also makes this group-readable: shouldn't this chmod() be done only if the chown() succeeds?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.