Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: drop "autoattachinterval" from the rhsmcertd defaults #3472

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

ptoscano
Copy link
Contributor

That configuration option was recently removed, so there is no more need to specify a default value for it.

Fixes CCT-966

Followup of commit c124784.

That configuration option was recently removed, so there is no more need
to specify a default value for it.

Fixes CCT-966

Followup of commit c124784.
@cnsnyder cnsnyder requested review from a team and pkoprda and removed request for a team November 12, 2024 17:18
Copy link

Coverage

Coverage (computed on Fedora latest) •
FileStmtsMissCoverMissing
rhsm
   config.py178994%155, 168, 180–181, 230, 393–394, 400, 409
TOTAL17676455774% 

Tests Skipped Failures Errors Time
2471 14 💤 0 ❌ 0 🔥 31.305s ⏱️

Copy link
Contributor

@pkoprda pkoprda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pkoprda pkoprda merged commit 9f8f921 into main Nov 13, 2024
17 checks passed
@ptoscano ptoscano deleted the ptoscano/CCT-966 branch November 13, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants