Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Added initial support for tmt #3473

Merged
merged 2 commits into from
Dec 9, 2024
Merged

fix: Added initial support for tmt #3473

merged 2 commits into from
Dec 9, 2024

Conversation

jirihnidek
Copy link
Contributor

@jirihnidek jirihnidek commented Nov 15, 2024 •
edited
Loading

  • Card ID: CCT-741
  • Renamed directory ./integration-tests to ./cockpit-tests
    • The new name describes better the purpose of the directory
    • We are going to add real integration tests and there would be interference in names
  • Added basic configuration for tmt
    • subscription-manager is installed from COPR build
    • Python virtual environment is created
    • Install testing framework
    • Some simple smoke test is run (busctl calls RHSM D-Bus method)

@cnsnyder cnsnyder requested review from a team and m-horky and removed request for a team November 15, 2024 15:58
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 15, 2024 •
edited
Loading

Coverage

Coverage (computed on Fedora latest) •
FileStmtsMissCoverMissing
__init__.py00100% 
TOTAL17674455174% 

Tests Skipped Failures Errors Time
2470 14 💤 0 ❌ 0 🔥 33.339s ⏱️

@jirihnidek jirihnidek changed the title fix: Renamed integration-tests to cockpit-tests fix: Added initial support for tmt Nov 20, 2024
@jirihnidek jirihnidek force-pushed the jhnidek/tmt_init branch 2 times, most recently from dbb8a09 to 853f71f Compare December 2, 2024 15:53
@jirihnidek
fix: Renamed integration-tests to cockpit-tests
8e9ff09 
* Card ID: CCT-741
* The new name describes better the purpose of the directory
* We are going to add real integration tests and there would
  be interference in names
@jirihnidek
feat: Add initial support for tmt
57231d6 
* Card ID: CCT-741
* Added basic configuration for tmt
  - subscription-manager is installed from COPR build
  - Python virtual environment is created
  - Install testing framework
  - Some simple smoke test is run (busctl calls RHSM D-Bus method)
@jirihnidek jirihnidek marked this pull request as ready for review December 2, 2024 15:55
@cnsnyder cnsnyder requested a review from a team December 2, 2024 15:55
jstavel
jstavel approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@jstavel jstavel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I can understand what's going in the code - ie. it is OK for me. Thanks.

m-horky
m-horky approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@m-horky m-horky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@m-horky m-horky merged commit 5365981 into main Dec 9, 2024
25 checks passed
@m-horky m-horky deleted the jhnidek/tmt_init branch December 9, 2024 14:05
@jirihnidek jirihnidek mentioned this pull request Dec 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-horky m-horky m-horky approved these changes

@jstavel jstavel jstavel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jirihnidek @jstavel @m-horky