chore: Remove artifacts of removed commands

[Glutexo]

Removed what remained after removing obsolete commands.

• attach and partially --auto_attach in feat: Removed attach command #3409
• rest of --auto_attach and autodial in feat: Remove auto-attach command #3451
• remove in feat: Eliminate command 'remove' from subscription-manager #3444
• addons, role, service-level, and usage in feat: Remove deprecated syspurpose top-level commands #3417
• redeem in feat: Removed command "redeem" from subscription-manager #3446
• import in feat: Remove import command #3425

There is more obsolete code to be removed, e.g. in EntitlementDBusObject. That’d be over the scope of this pull request, though.

Card IDs:

• CCT-603

[Glutexo]

In this commit, I removed everything related to the attach CLI command. It doesn’t deal with the --auto-attach option of the register command. I know only little about Subscription Manager, so I did so mostly blindly, only after a short conversation with Matyáš. @pinotree, may I ask you to take a look?

[Glutexo]

I created this pull request as a draft, thinking that I’d put in the command removals as individual commits. If @pinotree approves, however, I think we can merge and do the other commands in (a) new pull request(s).

[ptoscano]

Removed what remained after removing the attach CLI command.

strictly speaking, this also removes other references related to "attach" (eg dbus, in some old/unused tests, etc), not only in the CLI

[Glutexo]

@ptoscano Thank you for the review! 🙇🏻‍♂️ I addressed your comments.

I un-drafted the PR, so it can be merged if you approve of the changes. There are already 10 changed files. That’s enough for a single PR.

[Glutexo]

After a discussion with Barbora and Matyáš, we agreed to rather put the command removals into this pull request as individual commits:

• chore: Remove artifacts of --auto-attach #3478 with Pino’s review comments addressed as b5d200b
• chore: Remove artifacts of autoheal #3479 with Pino’s review comments addressed as 8b1dca9

[Glutexo]

Matyáš suggested we can be more aggressive removing code that seems unused. The reasoning was that either integration tests would fail, or QE would find an issue when doing manual testing.

Under that suggestion, I removed quite some methods from EntitlementService and EntitlementDBusObject that doesn’t seem to be called or referenced from anywhere. Added a commit 8c3400b.

[Glutexo]

Added fda942a removing artifacts of the redeem command.

[Glutexo]

Added 516d70b removing artifacts of the import command.

[Glutexo]

bindByEntitlementPool and bind weren’t used anywhere after the attach command disappeared. Removed.

[Glutexo]

I merged all the “chore: remove artifacts” pull requests into this one. Removal of every command/option artifacts is in an individual commit. That should make a review easier even though there are many changed files and lines.

I only removed artifacts remaining after what’s been removed in the referenced removal pull requests. I went through their code once more to remove deeper artifacts: methods called by methods (…) called by the removed methods.

• feat: Removed attach command #3409
• feat: Remove auto-attach command #3451
• feat: Eliminate command 'remove' from subscription-manager #3444
• feat: Remove deprecated syspurpose top-level commands #3417
• feat: Removed command "redeem" from subscription-manager #3446
• feat: Remove import command #3425

There is more obsolete code to be removed. An example is the EntitlementDBusObject: all its methods except GetStatus are not called from anywhere and aren’t referenced in the DBus conf file. I’d keep that for a separate card and pull request though.

I’d like to ask for a real and full review, now. @ptoscano, please. 🙏🏻

[ptoscano]

Thanks!