-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration Tests for DBus Register Method #3477
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, it looks good. 👍 I know that this is WIP. I have few comments and suggestions ATM.
75e897a
to
9ce9c9a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR 👍 . Overall it is good. I have few requests and comments.
@jstavel commit message and PR comment should contain reference on the card. Something like: |
9ce9c9a
to
6a6e893
Compare
6a6e893
to
a746f6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Failed jobs (centos10) seems not related to this PR.
tests for DBus API Register object. The tests cover main use cases for registration of a system.