Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration Tests for DBus Register Method #3477

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

jstavel
Copy link
Contributor

@jstavel jstavel commented Nov 29, 2024

tests for DBus API Register object. The tests cover main use cases for registration of a system.

@cnsnyder cnsnyder requested review from a team and jirihnidek and removed request for a team November 29, 2024 01:54
Copy link

github-actions bot commented Nov 29, 2024

Coverage

Coverage (computed on Fedora latest) •
FileStmtsMissCoverMissing
TOTAL17411449374% 
report-only-changed-files is enabled. No files were changed during this commit :)

Tests Skipped Failures Errors Time
2411 14 💤 0 ❌ 0 🔥 31.446s ⏱️

Copy link
Contributor

@jirihnidek jirihnidek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it looks good. 👍 I know that this is WIP. I have few comments and suggestions ATM.

integration-tests/conftest.py Outdated Show resolved Hide resolved
integration-tests/conftest.py Show resolved Hide resolved
integration-tests/dev-requirements.txt Outdated Show resolved Hide resolved
integration-tests/test_register.py Outdated Show resolved Hide resolved
@jstavel jstavel changed the title WIP: Jstavel/dbus integration tests WIP: DBus integration tests for Register method Dec 12, 2024
@jstavel jstavel changed the title WIP: DBus integration tests for Register method DBus integration tests for Register method Dec 12, 2024
@jstavel jstavel changed the title DBus integration tests for Register method Integration Tests for DBus Register Method Dec 12, 2024
@jstavel jstavel force-pushed the jstavel/dbus-integration-tests branch 2 times, most recently from 75e897a to 9ce9c9a Compare December 13, 2024 13:42
Copy link
Contributor

@jirihnidek jirihnidek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR 👍 . Overall it is good. I have few requests and comments.

integration-tests/README.md Show resolved Hide resolved
integration-tests/README.md Show resolved Hide resolved
integration-tests/README.md Outdated Show resolved Hide resolved
integration-tests/conftest.py Outdated Show resolved Hide resolved
integration-tests/conftest.py Outdated Show resolved Hide resolved
integration-tests/scripts/post-activation-keys.sh Outdated Show resolved Hide resolved
integration-tests/test_register.py Outdated Show resolved Hide resolved
integration-tests/test_register.py Outdated Show resolved Hide resolved
@jirihnidek
Copy link
Contributor

@jstavel commit message and PR comment should contain reference on the card. Something like: Card ID: CCT-731. Please, try to be more descriptive in the commit message. Thanks

@jstavel jstavel force-pushed the jstavel/dbus-integration-tests branch from 9ce9c9a to 6a6e893 Compare December 16, 2024 22:36
@jstavel jstavel force-pushed the jstavel/dbus-integration-tests branch from 6a6e893 to a746f6f Compare December 17, 2024 06:53
Copy link
Contributor

@jirihnidek jirihnidek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Failed jobs (centos10) seems not related to this PR.

@jirihnidek jirihnidek merged commit d6b8040 into main Dec 17, 2024
21 of 24 checks passed
@jirihnidek jirihnidek deleted the jstavel/dbus-integration-tests branch December 17, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants