fix: Append two additional facts to the graylist #3520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptoscano
requested changes
Feb 27, 2025
There was a problem hiding this comment.
Not bad, however there is duplicate code/information /o\
Since we are changing this, what about doing a small refactor to make this kind of change easier in the future? What I'm thinking is:
- make the graylist in
FactsDicta class constant, i.e. naming itUPPERCASE_LIKE_THIS, - use that contant in the
Factsclass; interesting bit is thatFacts.graylistis alist, but then when used a newsetis created from it...
I recommend splitting this in two commit:
- one commit doing the refactoring for the constant and using it in the other class as set already
- adding the new facts to the de-duplicated graylist of facts
Thanks!
ptoscano
requested changes
Mar 3, 2025
debarshiray
reviewed
Mar 3, 2025
There was a problem hiding this comment.
The libdnf (Fedora Rawhide, registry.fedoraproject.org/fedora:rawhide) test failed with:
CMake Error at CMakeLists.txt:1 (CMAKE_MINIMUM_REQUIRED):
Compatibility with CMake < 3.5 has been removed from CMake.
Update the VERSION argument <min> value. Or, use the <min>...<max> syntax
to tell CMake that the project requires at least <min> but has been updated
to work with policies introduced by <max> or earlier.
Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.
It might be fixed by #3521
* Card ID: CCT-1023 Variable for graylist of facts is known to change frequently. To reduce the code duplication, this commit changes the variable graylist of facts to class constant, which can be easily used in other classes.
* Card ID: CCT-1023 This update appends two additional CPU-related facts to the graylist. The graylist currently includes `cpu.cpu_mhz` and `lscpu.cpu_mhz`, but RHEL 9.6 and 10.0 add more CPU facts that also vary frequently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update appends two additional CPU-related facts to the graylist. The graylist currently includes
cpu.cpu_mhzandlscpu.cpu_mhz, but RHEL 9.6 and 10.0 add more CPU facts that also vary frequently.