Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid boxing where possible #1117

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Avoid boxing where possible #1117

wants to merge 15 commits into from

Conversation

JonasWanke
Copy link
Member

Fibonacci 37 got sped up from 8 s to 0.4 s

Checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

@JonasWanke JonasWanke added the T: Performance Type: Performance Improvements label Feb 6, 2025
@JonasWanke JonasWanke self-assigned this Feb 6, 2025
@jwbot jwbot added P: Compiler: Language Server Package: The Candy Language Server P: Compiler: Frontend Package: The compiler frontend P: Compiler: VS Code Extension Package: The Candy VS Code Extension P: Compiler: Fuzzer Package: Candy's built-in fuzzer fuzzing Candy code P: Compiler: VM Package: The VM executing Candy byte code (LIR) P: Compiler: CLI Package: Candy's command-line interface P: Compiler: Formatter Package: Candy's formatter P: Compiler: Inkwell Backend Package: Inkwell Compiler Backend producing native code via LLVM P: Compiler v4 Package: Compiler v4 P: Compiler: VS Code Extension v4 labels Feb 6, 2025
@jwbot jwbot enabled auto-merge February 6, 2025 20:12
MarcelGarus
MarcelGarus approved these changes Feb 7, 2025
View reviewed changes
vscode_extension_v4/src/extension.ts
Comment on lines +19 to +22
// Updates can be triggered very frequently (on every keystroke), but they can
// take long – for example, when editing the Candy compiler itself, simply
// analyzing the files takes some time. Thus, here we make sure that only one
// update runs at a time.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment only applies to self-hosted compilers, I think 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcelGarus MarcelGarus MarcelGarus approved these changes

Assignees

@JonasWanke JonasWanke

Labels
P: Compiler: CLI Package: Candy's command-line interface P: Compiler: Formatter Package: Candy's formatter P: Compiler: Frontend Package: The compiler frontend P: Compiler: Fuzzer Package: Candy's built-in fuzzer fuzzing Candy code P: Compiler: Inkwell Backend Package: Inkwell Compiler Backend producing native code via LLVM P: Compiler: Language Server Package: The Candy Language Server P: Compiler v4 Package: Compiler v4 P: Compiler: VM Package: The VM executing Candy byte code (LIR) P: Compiler: VS Code Extension v4 P: Compiler: VS Code Extension Package: The Candy VS Code Extension T: Performance Type: Performance Improvements
Projects
🍭 Candy
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JonasWanke @MarcelGarus @jwbot