Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tests for IE11 #308

Merged
merged 1 commit into from
Nov 7, 2018
Merged

fix tests for IE11 #308

merged 1 commit into from
Nov 7, 2018

Conversation

cherifGsoul
Copy link
Member

@cherifGsoul cherifGsoul mentioned this pull request Nov 6, 2018
Closed
phillipskevin
phillipskevin requested changes Nov 7, 2018
View reviewed changes
Copy link
Contributor

@phillipskevin phillipskevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the tests-without-observe.js file needed?

@cherifGsoul
Copy link
Member Author

@phillipskevin Yes is needed to not test can-observe (Proxy) in IE11

@cherifGsoul cherifGsoul merged commit 6039e4f into master Nov 7, 2018
@cherifGsoul cherifGsoul deleted the ie11-compat branch November 7, 2018 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillipskevin phillipskevin phillipskevin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cherifGsoul @phillipskevin