fixing tests using Symbols for IE11 #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IE11 does not support Symbols, so can-symbol falls back to using string keys. These keys are included when running deepEqual on the result of expression.parse, whereas they are not when Symbols are used. To fix these tests, I included the value stored to these keys in the expected value that is passed to deepEqual.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IE11 does not support Symbols, so can-symbol falls back to using string
keys. These keys are included when running deepEqual on the result of
expression.parse, whereas they are not when Symbols are used. To fix
these tests, I included the value stored to these keys in the expected
value that is passed to deepEqual.
part of canjs/canjs#4115.