-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial explanation for crypto used by AMS #114
Conversation
@keirthana I've added this as a draft here for now as we need to discuss where to put this best. This form satisfies SEC0030 and will need to be repeated for all other services / components. |
@morphis Yes, there should be a separate section for cryptography. Let me set that up through another PR. Before that, this is targeted for 1.24 right? In that case, I will set up a branch for 1.24 on the repo - I know we still have versioning to be spec'ed out but we might need something in place for current work. |
This is fine to go in any time, not tied to a release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes, otherwise looks good!
@morphis I had a closer look at this and I see that you have created the structure in place with the security folder. So let's go ahead with this and move things around when more information is available. Left a few suggestions to improve readability, otherwise LGTM. |
Everyone contributing to this PR have now signed the CLA. Thanks! |
59e4c1d
to
ea56896
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.