Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial explanation for crypto used by AMS #114

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

morphis
Copy link
Collaborator

@morphis morphis commented Aug 15, 2024

No description provided.

@morphis
Copy link
Collaborator Author

morphis commented Aug 15, 2024

@keirthana I've added this as a draft here for now as we need to discuss where to put this best. This form satisfies SEC0030 and will need to be repeated for all other services / components.

@keirthana
Copy link
Collaborator

@keirthana I've added this as a draft here for now as we need to discuss where to put this best. This form satisfies SEC0030 and will need to be repeated for all other services / components.

@morphis Yes, there should be a separate section for cryptography. Let me set that up through another PR. Before that, this is targeted for 1.24 right? In that case, I will set up a branch for 1.24 on the repo - I know we still have versioning to be spec'ed out but we might need something in place for current work.

@morphis
Copy link
Collaborator Author

morphis commented Aug 19, 2024

@keirthana I've added this as a draft here for now as we need to discuss where to put this best. This form satisfies SEC0030 and will need to be repeated for all other services / components.

@morphis Yes, there should be a separate section for cryptography. Let me set that up through another PR. Before that, this is targeted for 1.24 right? In that case, I will set up a branch for 1.24 on the repo - I know we still have versioning to be spec'ed out but we might need something in place for current work.

This is fine to go in any time, not tied to a release

Copy link
Collaborator

@keirthana keirthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes, otherwise looks good!

explanation/security/crypto_ams.md Outdated Show resolved Hide resolved
explanation/security/crypto_ams.md Outdated Show resolved Hide resolved
explanation/security/crypto_ams.md Outdated Show resolved Hide resolved
explanation/security/crypto_ams.md Outdated Show resolved Hide resolved
explanation/security/crypto_ams.md Outdated Show resolved Hide resolved
@keirthana
Copy link
Collaborator

@keirthana I've added this as a draft here for now as we need to discuss where to put this best. This form satisfies SEC0030 and will need to be repeated for all other services / components.

@morphis Yes, there should be a separate section for cryptography. Let me set that up through another PR. Before that, this is targeted for 1.24 right? In that case, I will set up a branch for 1.24 on the repo - I know we still have versioning to be spec'ed out but we might need something in place for current work.

This is fine to go in any time, not tied to a release

@morphis I had a closer look at this and I see that you have created the structure in place with the security folder. So let's go ahead with this and move things around when more information is available. Left a few suggestions to improve readability, otherwise LGTM.

@morphis morphis requested a review from keirthana August 20, 2024 07:10
Copy link
Contributor

github-actions bot commented Aug 20, 2024

Everyone contributing to this PR have now signed the CLA. Thanks!

@morphis morphis marked this pull request as ready for review August 20, 2024 13:11
@morphis morphis force-pushed the add-ams-crypto-exp branch from 59e4c1d to ea56896 Compare August 20, 2024 13:14
Copy link
Collaborator

@keirthana keirthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ajanon ajanon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keirthana keirthana merged commit 45b795f into canonical:main Aug 27, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants