Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(howto): Change VNDK version for custom VHAL to 34 #125

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

ajanon
Copy link
Contributor

@ajanon ajanon commented Aug 28, 2024

Since 1.23.0, we have switch to a new VNDK version, and we seemed to have missed updating related documentation.

Since 1.23.0, we have switch to a new VNDK version, and we seemed to have missed
updating related documentation.
@ajanon
Copy link
Contributor Author

ajanon commented Aug 28, 2024

@keirthana Do you think we should do something more here? Adding this to the release notes for 1.23.1 as something we missed maybe? Wdyt?

@ajanon ajanon requested a review from keirthana August 28, 2024 10:30
Copy link
Collaborator

@morphis morphis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@morphis
Copy link
Collaborator

morphis commented Aug 28, 2024

@keirthana Do you think we should do something more here? Adding this to the release notes for 1.23.1 as something we missed maybe? Wdyt?

We should mention it but we can release the change ASAP.

@keirthana
Copy link
Collaborator

@keirthana Do you think we should do something more here? Adding this to the release notes for 1.23.1 as something we missed maybe? Wdyt?

I don't think it is a good idea to retrospectively update the release notes. Fixing the documentation should be enough.

@keirthana keirthana merged commit fe40aee into canonical:main Aug 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants