-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update client-side video upscaling
for multi-pass shader support
#135
Conversation
It's targeting for 1.24 release and for now, it's pending until the following canonical/anbox-streaming-sdk#55 is landed. |
0cb00b8
to
7ebcc3a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@keirthana we need to whitelist the git revision from the image version.
And the revision number recorded in the table is |
An easy and dirty hack is to enclose the revision in backticks. If it is fixed as |
A: I guess you meant to say
A: As I mentioned above, they're dynamic ones as always, in the next patch release, that would be another new one in the format like Also adding backticks doesn't work for me either when I ran the spellcheck locally. |
No, I meant if it is fixed, meaning if it will always be 'ba', we can include that in the custom_wordlist so that the spellcheck would ignore it. Anyway, I can see that it keeps changing
I have pushed a change with the backticks, if you rebase your branch on top of main, that should do it. |
|
…-pass shader support Update `client-side video upscaling` section for multi-pass shader support in streaming SDK.
7ebcc3a
to
b16804c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Update
client-side video upscaling
section for multi-pass shader support in streaming SDK.