Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update client-side video upscaling for multi-pass shader support #135

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

adglkh
Copy link
Contributor

@adglkh adglkh commented Sep 9, 2024

Update client-side video upscaling section for multi-pass shader support in streaming SDK.

@adglkh
Copy link
Contributor Author

adglkh commented Sep 9, 2024

It's targeting for 1.24 release and for now, it's pending until the following canonical/anbox-streaming-sdk#55 is landed.

@adglkh adglkh force-pushed the multi_pass_support branch from 0cb00b8 to 7ebcc3a Compare September 9, 2024 08:49
@keirthana keirthana added this to the 1.24.0 milestone Sep 9, 2024
Copy link
Collaborator

@keirthana keirthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adglkh
Copy link
Contributor Author

adglkh commented Sep 9, 2024

@keirthana we need to whitelist the git revision from the image version.
E.g.

The HTML pages are in _build.
. .sphinx/venv/bin/activate ; python3 -m pyspelling -c .sphinx/spellingcheck.yaml -j 4
Misspelled words:
<htmlcontent> _build/reference/component-versions/index.html: html>body>div>div>div>div>article>section>section>section>div>table>tbody>tr>td>p
--------------------------------------------------------------------------------
ba
--------------------------------------------------------------------------------

And the revision number recorded in the table is
| jammy:android13:amd64 | 1.23.0-20240809080136.4a6ba963a |
This revision number changes dynamically with each release. How can we resolve this without hardcoding the revision number in .wordlist.txt?

@keirthana
Copy link
Collaborator

@keirthana we need to whitelist the git revision from the image version. E.g.

The HTML pages are in _build.
. .sphinx/venv/bin/activate ; python3 -m pyspelling -c .sphinx/spellingcheck.yaml -j 4
Misspelled words:
<htmlcontent> _build/reference/component-versions/index.html: html>body>div>div>div>div>article>section>section>section>div>table>tbody>tr>td>p
--------------------------------------------------------------------------------
ba
--------------------------------------------------------------------------------

And the revision number recorded in the table is | jammy:android13:amd64 | 1.23.0-20240809080136.4a6ba963a | This revision number changes dynamically with each release. How can we resolve this without hardcoding the revision number in .wordlist.txt?

An easy and dirty hack is to enclose the revision in backticks. If it is fixed as ba, we could include it in the custom_wordlist but if it is a dynamic one, use backticks for now until we have a better solution.

@adglkh
Copy link
Contributor Author

adglkh commented Sep 9, 2024

An easy and dirty hack is to enclose the revision in backticks. If it is fixed as ba, we could include it in the custom_wordlist but if it is a dynamic one, use backticks for now until we have a better solution.

A: I guess you meant to say If it is *NOT* fixed as ba, we could include it in the custom_wordlist...

but if it is a dynamic one, use backticks for now until we have a better solution.

A: As I mentioned above, they're dynamic ones as always, in the next patch release, that would be another new one in the format like 1.23.0-2024080918xxxx.<git-revsion>, hence adding the word to the custom_wordlist is not an option.

Also adding backticks doesn't work for me either when I ran the spellcheck locally.

@keirthana
Copy link
Collaborator

keirthana commented Sep 9, 2024

An easy and dirty hack is to enclose the revision in backticks. If it is fixed as ba, we could include it in the custom_wordlist but if it is a dynamic one, use backticks for now until we have a better solution.

A: I guess you meant to say If it is *NOT* fixed as ba, we could include it in the custom_wordlist...

No, I meant if it is fixed, meaning if it will always be 'ba', we can include that in the custom_wordlist so that the spellcheck would ignore it. Anyway, I can see that it keeps changing

but if it is a dynamic one, use backticks for now until we have a better solution.

A: As I mentioned above, they're dynamic ones as always, in the next patch release, that would be another new one in the format like 1.23.0-2024080918xxxx.<git-revsion>, hence adding the word to the custom_wordlist is not an option.

Also adding backticks doesn't work for me either when I ran the spellcheck locally.

I have pushed a change with the backticks, if you rebase your branch on top of main, that should do it.

@adglkh
Copy link
Contributor Author

adglkh commented Sep 13, 2024

An easy and dirty hack is to enclose the revision in backticks. If it is fixed as ba, we could include it in the custom_wordlist but if it is a dynamic one, use backticks for now until we have a better solution.

A: I guess you meant to say If it is *NOT* fixed as ba, we could include it in the custom_wordlist...

No, I meant if it is fixed, meaning if it will always be 'ba', we can include that in the custom_wordlist so that the spellcheck would ignore it. Anyway, I can see that it keeps changing
A: Okay, sorry for the misunderstanding.

but if it is a dynamic one, use backticks for now until we have a better solution.

A: As I mentioned above, they're dynamic ones as always, in the next patch release, that would be another new one in the format like 1.23.0-2024080918xxxx.<git-revsion>, hence adding the word to the custom_wordlist is not an option.
Also adding backticks doesn't work for me either when I ran the spellcheck locally.

I have pushed a change with the backticks, if you rebase your branch on top of main, that should do it.
A: thanks for the fixing.

…-pass shader support

Update `client-side video upscaling` section for multi-pass shader
support in streaming SDK.
@adglkh adglkh requested a review from a team as a code owner September 13, 2024 01:52
Copy link
Contributor

@ajanon ajanon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adglkh adglkh changed the base branch from main to next-release October 9, 2024 11:57
@keirthana keirthana merged commit ae8691d into canonical:next-release Oct 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants