Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automate loading of AMS and Gateway API spec from swagger #147

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Automate loading of AMS and Gateway API spec from swagger #147

merged 1 commit into from
Sep 20, 2024

Conversation

keirthana
Copy link
Collaborator

No description provided.

@keirthana keirthana marked this pull request as draft September 18, 2024 06:14
@keirthana keirthana force-pushed the automate-api-docs branch 3 times, most recently from 297c244 to 9f559f4 Compare September 18, 2024 16:26
@morphis
Copy link
Collaborator

morphis commented Sep 18, 2024

@keirthana let me know when this is ready. It looks really nice already but two things I noticed:

  1. There are now two entries in the navigation saying "Main API specification"
  2. In the dark theme the API spec doesn't look great

image

@keirthana keirthana changed the base branch from content-automation to main September 19, 2024 06:07
@keirthana keirthana changed the base branch from main to content-automation September 19, 2024 06:08
@keirthana keirthana marked this pull request as ready for review September 19, 2024 06:08
@keirthana
Copy link
Collaborator Author

@keirthana let me know when this is ready. It looks really nice already but two things I noticed:

It is ready for review. I have based it on the content automation branch to see how it responds on RTD and it looks good.

1. There are now two entries in the navigation saying "Main API specification"

I have updated the titles now.

2. In the dark theme the API spec doesn't look great

Agreed, but I am not sure if there is anything we can do about it for now, let me check some options.

image

@keirthana keirthana merged commit 6a52890 into canonical:content-automation Sep 20, 2024
2 of 3 checks passed
@keirthana keirthana deleted the automate-api-docs branch September 24, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keirthana @morphis