Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ref): put links into code blocks to avoid linkcheck #221

Closed
wants to merge 1 commit into from

Conversation

morphis
Copy link
Collaborator

@morphis morphis commented Nov 15, 2024

The addresses used in the examples should not be checked by the link checker as they are not accessible and cause the check to timeout.

The addresses used in the examples should not be checked by the link
checker as they are not accessible and cause the check to timeout.
@morphis morphis requested a review from a team as a code owner November 15, 2024 18:55
Copy link
Contributor

@adglkh adglkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keirthana
Copy link
Collaborator

@morphis These files are autogenerated and hence this needs to be fixed at the source. Else they will get overwritten the next time the command reference is generated. See https://github.com/canonical/anbox-cloud-docs/blob/main/.github/workflows/generate-command-reference.yml

Copy link
Collaborator

@keirthana keirthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be updated here but rather in the appliance source code since this is generated by running the sudo anbox-cloud-appliance generate documentation -f markdown command

@morphis morphis closed this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants