Fix documentation around --enable-graphics flag

[keirthana]

Fixes #216

[adglkh]

While reading this page, another question came to mind: with the recently added CLI flag --enable-streaming to amc launch comman, the webrtc platform will be used in such cases. Since the webrtc platform automatically detects the GPU and adjusts rendering or video encoding capabilities (software vs hardware) accordingly, should we mention this on this page as well?

[keirthana]

While reading this page, another question came to mind: with the recently added CLI flag --enable-streaming to amc launch comman, the webrtc platform will be used in such cases. Since the webrtc platform automatically detects the GPU and adjusts rendering or video encoding capabilities (software vs hardware) accordingly, should we mention this on this page as well?

I have added a note because it is worth informing the user that there is another flag (--enable-streaming) that could influence the rendering platform used.

[ajanon]

LGTM

[adglkh]

LGTM

[morphis]

Overall reads much better but we should still get rid of the platform usage as IMHO it might add more confusion/involves another advanced topic the user might not care about to know at this point. Wdyt?

[adglkh]

get rid of the platform usage as IMHO it might add more confusion/involves another advanced topic the user might not care about to know at this point. Wdyt?

A: Yeah, sort of. However, if we want to remove the platform context here, we should avoid mentioning software and hardware rendering or video encoding (which are the focus of the chapter about using the GPU in instances). Instead, we should only refer to the visual output, which could be influenced by the --enable-graphics flag. In other word, the --enable-graphics flag doesn't directly determine whether the GPU is used or not; it only decides whether there is visual output from the instance.

[morphis]

get rid of the platform usage as IMHO it might add more confusion/involves another advanced topic the user might not care about to know at this point. Wdyt?

A: Yeah, sort of. However, if we want to remove the platform context here, we should avoid mentioning software and hardware rendering or video encoding (which are the focus of the chapter about using the GPU in instances). Instead, we should only refer to the visual output, which could be influenced by the --enable-graphics flag. In other word, the --enable-graphics flag doesn't directly determine whether the GPU is used or not; it only decides whether there is visual output from the instance.

We are in a page titled "GPUs and instances" so why shouldn't we talk about hardware rendering and video encoding? Both are essential functionalities we use from a GPU.

We need to explain the --enable-graphics switch as even if you assign a GPU to the instance you won't get it being used by Anbox unless you have it set.

[keirthana]

@morphis @adglkh I have rearranged the entire topic to focus on graphical rendering based on the --enable-graphics flag. Please have a look.

I intentionally removed the information about --enable-streaming flag that we had in the earlier round, as it spoke about the rendering platform rather than the purpose of use.

[morphis]

LGTM!

[morphis]

@adglkh do you want to take another look?

[adglkh]

LGTM