-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update create and delete applications details #259
Conversation
f0d3c32
to
5c43e8e
Compare
Is this for 1.25 too? If it is, please see my comment on your other PR: #260 (comment) |
This can be merged right away, it isn't targeted for 1.25 @ajanon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one rewrite required, all else looks good.
5c43e8e
to
840dbbe
Compare
840dbbe
to
a5a854f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add details for creating and deleting applications and creating instances.