Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update create and delete applications details #259

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

anusha-c18
Copy link
Collaborator

Add details for creating and deleting applications and creating instances.

@anusha-c18 anusha-c18 requested a review from a team as a code owner January 9, 2025 11:32
@anusha-c18 anusha-c18 force-pushed the add-details branch 2 times, most recently from f0d3c32 to 5c43e8e Compare January 9, 2025 12:20
@anusha-c18 anusha-c18 changed the title update create and delete applications and create instance details update create and delete applications details Jan 9, 2025
@ajanon
Copy link
Contributor

ajanon commented Jan 10, 2025

Is this for 1.25 too? If it is, please see my comment on your other PR: #260 (comment)

@anusha-c18
Copy link
Collaborator Author

This can be merged right away, it isn't targeted for 1.25 @ajanon

Copy link
Collaborator

@keirthana keirthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one rewrite required, all else looks good.

Copy link
Collaborator

@keirthana keirthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@morphis morphis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keirthana keirthana merged commit 2327c8d into canonical:main Jan 15, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants