Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to en-US #269

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Move to en-US #269

merged 1 commit into from
Jan 17, 2025

Conversation

keirthana
Copy link
Collaborator

Documentation changes

This PR changes the documentation style to en-US from en-GB aligning with company standards.

Review and preview

Have you reviewed and previewed your documentation updates?
Yes

Reviewers

Make sure to get at least one review from the Anbox team.

JIRA / Launchpad bug

n/a

@keirthana keirthana requested a review from a team as a code owner January 17, 2025 13:06
Copy link
Contributor

@ajanon ajanon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Will we also be required to change text in the code itself? e.g. for CLI help text, error messages, etc.

@keirthana
Copy link
Collaborator Author

LGTM. Will we also be required to change text in the code itself? e.g. for CLI help text, error messages, etc.

Ideally we should but I wouldn't place high priority on this. Going forward, all new usage should be following en-US and old instances can be corrected whenever possible.

@keirthana keirthana merged commit ae1b535 into canonical:main Jan 17, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants